Make all configmaps unique in same namespace #18620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
che-bot
added
the
status/code-review
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
skabashnyuk
requested review from
amisevsk,
metlos,
nickboldt and
sleshchenko
as code owners
mmorhun
reviewed
Dec 15, 2020
...clipse/che/workspace/infrastructure/kubernetes/provision/KubernetesTrustedCAProvisioner.java
Show resolved
Hide resolved
mshaposhnik
approved these changes
Dec 15, 2020
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
amisevsk
approved these changes
Dec 17, 2020
mmorhun
approved these changes
Dec 17, 2020
sparkoo
approved these changes
Dec 17, 2020
...clipse/che/workspace/infrastructure/kubernetes/provision/KubernetesTrustedCAProvisioner.java
Show resolved
Hide resolved
...n/java/org/eclipse/che/workspace/infrastructure/kubernetes/provision/SshKeysProvisioner.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
|
Test failed ❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
che-bot
added
kind/bug
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergii Kabashniuk skabashniuk@redhat.com
What does this PR do?
Make all configmaps unique in the same namespace.
UniqueNamesProvisionerto the end of the list of provisioners. After that, all config maps renamed and have the namewsid.originalnameScreenshot/screencast of this PR
Before the change. Openshift.
After the change Openshift
After the change Minikube
What issues does this PR fix or reference?
Fixes #18536
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.