Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new test constant for workspace stop timeout, 30s by default #18608

Conversation

ScrewTSW
Copy link
Member

What does this PR do?

  • Extends the amount of time the tests are waiting for the workspace to switch to stopped state

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

redhat-developer/rh-che#2025

How to test this PR?

  • Go into Eclipse repository che/tests/e2e
  • Run npm i and verify that all packages install without errors
  • Run tsc and verify that no errors are present
  • Export following variables:
    • TS_SELENIUM_BASE_URL
    • TS_SELENIUM_MULTIUSER=true
    • NODE_TLS_REJECT_UNAUTHORIZED=0
    • TS_SELENIUM_LOG_LEVEL="TRACE"
    • TS_SELENIUM_USERNAME
    • TS_SELENIUM_PASSWORD
  • Run npm run test-java-vertx to execute the smoke test devfile and verify that the tests are working correctly or run entire suite using npm run test-all-devfiles
  • Tests should pass without a failure

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. kind/periodic-e2e-test labels Dec 14, 2020
@che-bot
Copy link
Contributor

che-bot commented Dec 14, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@ScrewTSW
Copy link
Member Author

[ci-build]

@ScrewTSW ScrewTSW merged commit 88c0d1b into eclipse-che:master Dec 14, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants