Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Che server entrypoint script for case of commonly trusted certificate #18601

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Dec 11, 2020

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Fixes error in case if Che is secured by commonly trusted certificate

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

#18339

How to test this PR?

  1. Prepare an Openshift cluster configured with commonly trusted TLS certificate
  2. Configure additional TLS certificates for Che
  3. Deploy Eclipse Che using chectl

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…cate

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Dec 11, 2020
@tolusha tolusha mentioned this pull request Dec 11, 2020
56 tasks
@che-bot
Copy link
Contributor

che-bot commented Dec 11, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@mmorhun mmorhun merged commit 664b3d3 into master Dec 11, 2020
@mmorhun mmorhun deleted the che-18339-1 branch December 11, 2020 14:15
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants