Fix che-server when used external oidc provider. #18563

AndrienkoAleksandr · 2020-12-08T22:10:29Z

What does this PR do?

Fix che-server when used external oidc provider.

What issues does this PR fix or reference?

#18553

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

dmytro-ndp · 2020-12-09T07:10:07Z

[crw-ci-test --rebuild]

che-bot · 2020-12-09T07:30:05Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

ibuziuk · 2020-12-09T12:21:55Z

@nickboldt please, apply this PR before releasing 7.23.0 #18539

ibuziuk

I believe some tests and refactoring would be really nice to have, Currently the process of assigning the userInfoEndpoint and jwksUriEndpoint is not straight forward

...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakSettings.java

skabashnyuk · 2020-12-09T13:31:47Z

Can we have a test for this change?

AndrienkoAleksandr · 2020-12-11T15:20:25Z

Code spitted and good covered by tests.

che-bot · 2020-12-11T15:21:51Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/OIDCInfoProvider.java

multiuser/keycloak/che-multiuser-keycloak-server/pom.xml

che-bot · 2020-12-14T16:41:39Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-12-15T09:25:54Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-12-15T09:49:59Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

ibuziuk · 2020-12-15T11:18:49Z

@AndrienkoAleksandr tried to verify the PR against Hosted Che but it fails for me on startup with the following error:

2020-12-15 11:14:53,412[ost-startStop-1]  [ERROR] [o.a.c.c.C.[.[localhost].[/api] 175]  - Exception sending context initialized event to listener instance of class [org.eclipse.che.inject.CheBootstrap]
com.google.inject.CreationException: Unable to create injector, see the following errors:

1) Could not find a suitable constructor in org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
  at org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider.class(OIDCInfoProvider.java:38)
  while locating org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider
    for the 12th parameter of org.eclipse.che.multiuser.keycloak.server.KeycloakSettings.<init>(KeycloakSettings.java:62)
  while locating org.eclipse.che.multiuser.keycloak.server.KeycloakSettings
    for the 1st parameter of org.eclipse.che.multiuser.keycloak.server.KeycloakConfigurationService.<init>(KeycloakConfigurationService.java:42)
  at org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakModule.configure(KeycloakModule.java:38) (via modules: org.eclipse.che.api.deploy.WsMasterModule -> org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakModule)

2) Could not find a suitable constructor in org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
  at org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider.class(OIDCInfoProvider.java:38)
  while locating org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider
    for the 12th parameter of org.eclipse.che.multiuser.keycloak.server.KeycloakSettings.<init>(KeycloakSettings.java:62)
  while locating org.eclipse.che.multiuser.keycloak.server.KeycloakSettings
    for the 4th parameter of org.eclipse.che.multiuser.keycloak.server.KeycloakUserRemover.<init>(KeycloakUserRemover.java:74)
  while locating org.eclipse.che.multiuser.keycloak.server.KeycloakUserRemover
    for field at org.eclipse.che.multiuser.keycloak.server.KeycloakUserRemover$RemoveUserListener.keycloakUserRemover(KeycloakUserRemover.java:175)
  at org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakUserRemoverModule.configure(KeycloakUserRemoverModule.java:20) (via modules: org.eclipse.che.api.deploy.WsMasterModule -> org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakUserRemoverModule)

3) Could not find a suitable constructor in org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
  at org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider.class(OIDCInfoProvider.java:38)
  while locating org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider
    for the 5th parameter of org.eclipse.che.multiuser.keycloak.server.KeycloakUserRemover.<init>(KeycloakUserRemover.java:74)
  while locating org.eclipse.che.multiuser.keycloak.server.KeycloakUserRemover
    for field at org.eclipse.che.multiuser.keycloak.server.KeycloakUserRemover$RemoveUserListener.keycloakUserRemover(KeycloakUserRemover.java:175)
  at org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakUserRemoverModule.configure(KeycloakUserRemoverModule.java:20) (via modules: org.eclipse.che.api.deploy.WsMasterModule -> org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakUserRemoverModule)

4) Could not find a suitable constructor in org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
  at org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider.class(OIDCInfoProvider.java:38)
  while locating org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider
    for the 12th parameter of org.eclipse.che.multiuser.keycloak.server.KeycloakSettings.<init>(KeycloakSettings.java:62)
  while locating org.eclipse.che.multiuser.keycloak.server.KeycloakSettings
    for the 2nd parameter of com.redhat.che.multitenant.Fabric8AuthServiceClient.<init>(Fabric8AuthServiceClient.java:72)
  at com.redhat.che.wsmaster.deploy.Fabric8WsMasterModule.configure(Fabric8WsMasterModule.java:38)

5) Could not find a suitable constructor in org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
  at org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider.class(OIDCInfoProvider.java:38)
  while locating org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider
    for the 3rd parameter of com.redhat.che.multitenant.Fabric8AuthServiceClient.<init>(Fabric8AuthServiceClient.java:72)
  at com.redhat.che.wsmaster.deploy.Fabric8WsMasterModule.configure(Fabric8WsMasterModule.java:38)

6) Could not find a suitable constructor in org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
  at org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider.class(OIDCInfoProvider.java:38)
  while locating org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider
    for the 12th parameter of org.eclipse.che.multiuser.keycloak.server.KeycloakSettings.<init>(KeycloakSettings.java:62)
  while locating org.eclipse.che.multiuser.keycloak.server.KeycloakSettings
    for the 2nd parameter of org.eclipse.che.workspace.infrastructure.openshift.multiuser.oauth.IdentityProviderConfigFactory.<init>(IdentityProviderConfigFactory.java:76)
  at org.eclipse.che.api.deploy.WsMasterModule.configureMultiUserMode(WsMasterModule.java:350)

7) Could not find a suitable constructor in org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
  at org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider.class(OIDCInfoProvider.java:38)
  while locating org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider
    for the 1st parameter of org.eclipse.che.multiuser.keycloak.server.KeycloakProfileRetriever.<init>(KeycloakProfileRetriever.java:39)
  while locating org.eclipse.che.multiuser.keycloak.server.KeycloakProfileRetriever
    for the 1st parameter of org.eclipse.che.multiuser.keycloak.server.dao.KeycloakProfileDao.<init>(KeycloakProfileDao.java:38)
  at org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakModule.configure(KeycloakModule.java:40) (via modules: org.eclipse.che.api.deploy.WsMasterModule -> org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakModule)

8) Could not find a suitable constructor in org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
  at org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider.class(OIDCInfoProvider.java:38)
  while locating org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider
    for the 1st parameter of org.eclipse.che.multiuser.keycloak.server.KeycloakJwkProvider.<init>(KeycloakJwkProvider.java:29)
  at org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakModule.configure(KeycloakModule.java:41) (via modules: org.eclipse.che.api.deploy.WsMasterModule -> org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakModule)

9) Could not find a suitable constructor in org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
  at org.eclipse.che.multiuser.keycloak.server.OIDCInfoProvider.class(OIDCInfoProvider.java:38)
  at org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakModule.configure(KeycloakModule.java:43) (via modules: org.eclipse.che.api.deploy.WsMasterModule -> org.eclipse.che.multiuser.keycloak.server.deploy.KeycloakModule)

9 errors
	at com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:543)
	at com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:159)
	at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:106)
	at com.google.inject.Guice.createInjector(Guice.java:87)
	at org.everrest.guice.servlet.EverrestGuiceContextListener.getInjector(EverrestGuiceContextListener.java:141)
	at com.google.inject.servlet.GuiceServletContextListener.contextInitialized(GuiceServletContextListener.java:45)
	at org.everrest.guice.servlet.EverrestGuiceContextListener.contextInitialized(EverrestGuiceContextListener.java:86)
	at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4689)
	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5155)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:743)
	at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:719)
	at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:705)
	at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:970)
	at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1840)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

Fixup applied on Hosted Che end - ibuziuk/rh-che@61841cb
image - quay.io/ibuziuk/che-server:oidc

...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/OIDCInfoProvider.java

che-bot · 2020-12-15T12:30:59Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

ibuziuk

Good job!
verified on che-dev with Hosted Che.
@AndrienkoAleksandr please cherry-pick to 7.23.x once merged

che-bot · 2020-12-15T23:20:39Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

…ider injection way. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

...ak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakServiceClient.java

ibuziuk · 2020-12-16T09:34:53Z

...ser-remover/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakUserRemover.java

@@ -69,23 +69,22 @@ public KeycloakUserRemover(
      @Nullable @Named("che.keycloak.cascade_user_removal_enabled") boolean userRemovalEnabled,
      @Nullable @Named("che.keycloak.admin_username") String keycloakUser,
      @Nullable @Named("che.keycloak.admin_password") String keycloakPassword,
-      KeycloakSettings keycloakSettings,
-      OIDCInfoProvider oidcInfoProvider,
+      @Nullable @Named(REALM_SETTING) String realm,


what is this new env var about and how is it documented?

That's known property. But if realm is null on the hosted Che, then I think remove user feature will be broken when this feature is enabled... I see that realm is required for https://github.com/eclipse/che/blob/7.23.x/multiuser/keycloak/che-multiuser-keycloak-user-remover/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakUserRemover.java#L89. But maybe it's not an issue if hosted Che doesn't supports this feature at all.

ibuziuk · 2020-12-16T10:11:32Z

@AndrienkoAleksandr tried the new version against Hosted Che and still theia is not loaded with the following error, but this does not look like related this PR:

vendors.536d8fc….js:365 
t {target: e, type: "error", message: "TIMEOUT", error: Error: TIMEOUT
    at e._handleTimeout (https://static.developers.redhat.com/che/theia_artifacts/ve…}
error: Error: TIMEOUT at e._handleTimeout (https://static.developers.redhat.com/che/theia_artifacts/vendors.536d8fc78a34456992cf.js:365:8016) at https://static.developers.redhat.com/che/theia_artifacts/vendors.536d8fc78a34456992cf.js:365:7896
message: "TIMEOUT"
target: e {_listeners: {…}, _retryCount: 4, _shouldReconnect: true, _connectLock: true, _binaryType: "blob", …}
type: "error"
__proto__: s

azatsarynnyy · 2020-12-16T10:40:53Z

hmm.. for some reason che-theia is not loaded for me properly, but this does not look like related to this PR:

{target: e, type: "error", message: "TIMEOUT", error: Error: TIMEOUT
    at e._handleTimeout (https://static.developers.redhat.com/che/theia_artifacts/ve…}
error: Error: TIMEOUT at e._handleTimeout (https://static.developers.redhat.com/che/theia_artifacts/vendors.536d8fc78a34456992cf.js:365:8016) at https://static.developers.redhat.com/che/theia_artifacts/vendors.536d8fc78a34456992cf.js:365:7896
message: "TIMEOUT"

@azatsarynnyy any ideas?

I can't reproduce that neither with che-theia:latest nor with che-theia:next. Everything is loaded correctly for me, on Hosted Che.
Maybe, it was some temporary issue with https://static.developers.redhat.com.
If you're able to reproduce it constantly, please provide the corresponding steps. I could check then.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

che-bot · 2020-12-16T11:22:08Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

test.sh

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr · 2020-12-16T13:01:41Z

I can't reproduce that neither with che-theia:latest nor with che-theia:next. Everything is loaded correctly for me, on Hosted Che.

+1. I can't reproduce it on the crc (openshift 4) cluster too.

che-bot · 2020-12-16T13:02:47Z

Test failed

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-12-16T13:02:48Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

ibuziuk · 2020-12-16T13:04:25Z

+1. I can't reproduce it on the crc (openshift 4) cluster too.

yeah theia loading, is not related to this PR

AndrienkoAleksandr · 2020-12-16T13:15:56Z

@skabashnyuk Could you review this pr, please?

ibuziuk · 2020-12-16T15:20:07Z

@rhopp @dmytro-ndp folks looks like e2e pr-check is fairly unstable - https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/Multiuser-Che-PR-check-E2E-Happy-path-tests-against-k8s/ how should we proceed? this change is needed to be backported to 7.23.x today

dmytro-ndp · 2020-12-16T15:34:02Z

[crw-ci-test --rebuild]

che-bot · 2020-12-16T15:57:41Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18563

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

AndrienkoAleksandr requested review from mshaposhnik and nickboldt as code owners December 8, 2020 22:10

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Dec 8, 2020

tolusha mentioned this pull request Dec 9, 2020

Che Deploy Sprint #194 #18542

Closed

56 tasks

tolusha approved these changes Dec 9, 2020

View reviewed changes

ibuziuk mentioned this pull request Dec 9, 2020

Release Che 7.23.0 #18539

Closed

12 tasks

ibuziuk reviewed Dec 9, 2020

View reviewed changes

...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakSettings.java Outdated Show resolved Hide resolved

ibuziuk reviewed Dec 9, 2020

View reviewed changes

...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakSettings.java Outdated Show resolved Hide resolved

This was referenced Dec 10, 2020

[Hosted Che] Failed to rollout 7.23.0-SNAPSHOT - Jwks endpoint url not found in keycloak #18553

Closed

Release Che 7.23.1 #18577

Closed

AndrienkoAleksandr requested a review from sparkoo as a code owner December 11, 2020 15:18

tolusha requested a review from skabashnyuk December 12, 2020 17:46

skabashnyuk reviewed Dec 12, 2020

View reviewed changes

ibuziuk reviewed Dec 14, 2020

View reviewed changes

multiuser/keycloak/che-multiuser-keycloak-server/pom.xml Show resolved Hide resolved

ibuziuk reviewed Dec 15, 2020

View reviewed changes

...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/OIDCInfoProvider.java Outdated Show resolved Hide resolved

ibuziuk reviewed Dec 15, 2020

View reviewed changes

...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/OIDCInfoProvider.java Show resolved Hide resolved

ibuziuk approved these changes Dec 15, 2020

View reviewed changes

AndrienkoAleksandr added 8 commits December 16, 2020 10:59

Fix che-server when used external oidc provider.

aef5780

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Split code KeycloakSettings logic. Cover code by tests.

4e16501

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Handle requested feedback.

b4120d4

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Inject provider.

2a4a7b3

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Fix format

31bdabd

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Fix injection again. I tested wrongly previous time.

ece12b5

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Fix bug with internal url after last commits refactoring. Change prov…

e195768

…ider injection way. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Cache OIDC settings result. Add more tests and java docs.

798b475

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

ibuziuk reviewed Dec 16, 2020

View reviewed changes

...ak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakServiceClient.java Outdated Show resolved Hide resolved

ibuziuk reviewed Dec 16, 2020

View reviewed changes

Make OIDCInfoProvider like singleton

07b109d

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr force-pushed the fix_che_server_when_used_external_oidc_provider branch from aaa275e to 07b109d Compare December 16, 2020 11:17

ibuziuk reviewed Dec 16, 2020

View reviewed changes

test.sh Outdated Show resolved Hide resolved

Clean up: Remove redudant changes.

c7b096a

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

skabashnyuk approved these changes Dec 16, 2020

View reviewed changes

AndrienkoAleksandr merged commit 7ee6ef3 into master Dec 16, 2020

AndrienkoAleksandr deleted the fix_che_server_when_used_external_oidc_provider branch December 16, 2020 16:02

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix che-server when used external oidc provider. #18563

Fix che-server when used external oidc provider. #18563

AndrienkoAleksandr commented Dec 8, 2020 •

edited by tolusha

Loading

dmytro-ndp commented Dec 9, 2020

che-bot commented Dec 9, 2020

ibuziuk commented Dec 9, 2020

ibuziuk left a comment

skabashnyuk commented Dec 9, 2020

AndrienkoAleksandr commented Dec 11, 2020 •

edited

Loading

che-bot commented Dec 11, 2020

che-bot commented Dec 14, 2020

che-bot commented Dec 15, 2020

che-bot commented Dec 15, 2020

ibuziuk commented Dec 15, 2020

che-bot commented Dec 15, 2020

ibuziuk left a comment

che-bot commented Dec 15, 2020

ibuziuk Dec 16, 2020

AndrienkoAleksandr Dec 16, 2020

ibuziuk commented Dec 16, 2020

azatsarynnyy commented Dec 16, 2020

che-bot commented Dec 16, 2020

AndrienkoAleksandr commented Dec 16, 2020

che-bot commented Dec 16, 2020

che-bot commented Dec 16, 2020

ibuziuk commented Dec 16, 2020 •

edited

Loading

AndrienkoAleksandr commented Dec 16, 2020

ibuziuk commented Dec 16, 2020

dmytro-ndp commented Dec 16, 2020

che-bot commented Dec 16, 2020

Fix che-server when used external oidc provider. #18563

Fix che-server when used external oidc provider. #18563

Conversation

AndrienkoAleksandr commented Dec 8, 2020 • edited by tolusha Loading

What does this PR do?

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

dmytro-ndp commented Dec 9, 2020

che-bot commented Dec 9, 2020

ibuziuk commented Dec 9, 2020

ibuziuk left a comment

Choose a reason for hiding this comment

skabashnyuk commented Dec 9, 2020

AndrienkoAleksandr commented Dec 11, 2020 • edited Loading

che-bot commented Dec 11, 2020

che-bot commented Dec 14, 2020

che-bot commented Dec 15, 2020

che-bot commented Dec 15, 2020

ibuziuk commented Dec 15, 2020

che-bot commented Dec 15, 2020

ibuziuk left a comment

Choose a reason for hiding this comment

che-bot commented Dec 15, 2020

ibuziuk Dec 16, 2020

Choose a reason for hiding this comment

AndrienkoAleksandr Dec 16, 2020

Choose a reason for hiding this comment

ibuziuk commented Dec 16, 2020

azatsarynnyy commented Dec 16, 2020

che-bot commented Dec 16, 2020

AndrienkoAleksandr commented Dec 16, 2020

che-bot commented Dec 16, 2020

che-bot commented Dec 16, 2020

ibuziuk commented Dec 16, 2020 • edited Loading

AndrienkoAleksandr commented Dec 16, 2020

ibuziuk commented Dec 16, 2020

dmytro-ndp commented Dec 16, 2020

che-bot commented Dec 16, 2020

AndrienkoAleksandr commented Dec 8, 2020 •

edited by tolusha

Loading

AndrienkoAleksandr commented Dec 11, 2020 •

edited

Loading

ibuziuk commented Dec 16, 2020 •

edited

Loading