Fix JavaSpringboot build task timeout #18487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
ScrewTSW
added
status/code-review
ScrewTSW
requested review from
musienko-maxim,
nickboldt and
rhopp
as code owners
che-bot
added
kind/bug
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
ScrewTSW
force-pushed
the
rhche2008-feature-fix-run-task-timeout
branch
from
12c8101
to
6575e84
Compare
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Katka92
approved these changes
Nov 30, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes Terminal.waitIconSuccess logic to use polling instead of driverHelper.waitScreenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
redhat-developer/rh-che#2008
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.