Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to replace backslash in usernames during first login #18425

Merged
merged 13 commits into from
Dec 2, 2020
Merged

Allow to replace backslash in usernames during first login #18425

merged 13 commits into from
Dec 2, 2020

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Nov 20, 2020 •
edited
Loading

Signed-off-by: Sergii Kabashniuk skabashniuk@redhat.com

What does this PR do?

Allow to replace backslash in usernames during first login

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#18404

How to test this PR?

  1. Deploy che without OpenShift OAuth integration chectl server:start --installer=operator --platform=openshift -n che --che-operator-cr-patch-yaml cr.yaml
spec:
  auth:
    openShiftoAuth: false

  1. Enable user self-registration in Che Keycloak realm
    Знімок екрана 2020-11-23 о 16 23 26

  2. Deploy che-server image quay.io/skabashn/che-server:che18404

  3. Register a new user with a backslash.
    Знімок екрана 2020-11-23 о 16 18 00

  4. Ensure that username in che doesn't contains backslash.
    Знімок екрана 2020-11-23 о 16 18 27

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@skabashnyuk
Allow to replace backslash in usernames during first login
69e1d9e 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Nov 20, 2020
@che-bot
Copy link
Contributor

che-bot commented Nov 20, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@skabashnyuk
Cleanup
96c78ac 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
fixup! Cleanup
6f58599 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 23, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@skabashnyuk skabashnyuk marked this pull request as ready for review November 23, 2020 14:39
@skabashnyuk
Merge remote-tracking branch 'upstream/master' into che18404
80b60df 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 25, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@skabashnyuk
Multi config
61a0640 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
Merge remote-tracking branch 'upstream/master' into che18404
96999b3 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
fixup! Merge remote-tracking branch 'upstream/master' into che18404
21db32b 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
fixup! fixup! Merge remote-tracking branch 'upstream/master' into che…
e6efdd3 
…18404

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 26, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@skabashnyuk
fixup! fixup! fixup! Merge remote-tracking branch 'upstream/master' i…
f323a38 
…nto che18404

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 26, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

metlos
metlos reviewed Nov 27, 2020
View reviewed changes
Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only wording suggestions, otherwise LGTM.

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/multiuser.properties Outdated Show resolved Hide resolved
.../java/org/eclipse/che/multiuser/keycloak/server/KeycloakEnvironmentInitializationFilter.java Outdated Show resolved Hide resolved
.../java/org/eclipse/che/multiuser/keycloak/server/KeycloakEnvironmentInitializationFilter.java Outdated Show resolved Hide resolved
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/multiuser.properties Outdated Show resolved Hide resolved
.../java/org/eclipse/che/multiuser/keycloak/server/KeycloakEnvironmentInitializationFilter.java Outdated Show resolved Hide resolved
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/multiuser.properties Outdated Show resolved Hide resolved
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/multiuser.properties Outdated Show resolved Hide resolved
@skabashnyuk
Merge remote-tracking branch 'upstream/master' into che18404
d89a7db 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
Fixup
611d510 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
Merge remote-tracking branch 'upstream/master' into che18404
ee3a046 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 30, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 30, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@skabashnyuk
Fix example, fix formatting
04096c5 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 30, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@skabashnyuk
Copy link
Contributor Author

[crw-ci-test]

@skabashnyuk
Copy link
Contributor Author

[crw-build]

@skabashnyuk
Copy link
Contributor Author

[ci-test]

@skabashnyuk
Copy link
Contributor Author

[ci-build]

@che-bot
Copy link
Contributor

che-bot commented Dec 1, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Katka92
Copy link
Contributor

Katka92 commented Dec 1, 2020

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Dec 1, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Dec 1, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@skabashnyuk skabashnyuk merged commit 84f83ab into eclipse-che:master Dec 2, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos left review comments

@sparkoo sparkoo sparkoo approved these changes

@mshaposhnik mshaposhnik mshaposhnik approved these changes

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

@nickboldt nickboldt Awaiting requested review from nickboldt

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skabashnyuk @che-bot @Katka92 @metlos @sparkoo @mshaposhnik