Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to define workspace deployment labels #18100

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Allow users to define workspace deployment labels #18100

merged 2 commits into from
Oct 27, 2020

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Oct 12, 2020 •
edited
Loading

What does this PR do?

MVP of ability to use workspace.attrubutes to allow a user to define workspace deployment labels and annotations.

Screenshot/screencast of this PR

Знімок екрана 2020-10-19 о 15 35 47

Знімок екрана 2020-10-19 о 15 35 31

What issues does this PR fix or reference?

fixes #18027

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Oct 12, 2020
@sparkoo
Copy link
Member

sparkoo commented Oct 13, 2020

so the reason for 2 new maps in KubernetesEnvironment is that we're provisioning pods, and we're merging them into one deployment in later startMachine() phase. Would it be possible to create the deployment sooner in provisioning phase? We should then be able to set the labels directly to it, right?

@sparkoo
Copy link
Member

sparkoo commented Oct 19, 2020

looks good

@eclipse-che eclipse-che deleted a comment from che-bot Oct 19, 2020
@dmytro-ndp
Copy link
Contributor

[crw-ci-test]

@skabashnyuk
Allow users to define workspace deployment labels and annotations via…
7482d6d 
… workspace attributes

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@eclipse-che eclipse-che deleted a comment from che-bot Oct 20, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Oct 20, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Oct 20, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Oct 20, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Oct 20, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Oct 20, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Oct 20, 2020
@skabashnyuk
Copy link
Contributor Author

[crw-ci-test]

@eclipse-che eclipse-che deleted a comment from che-bot Oct 20, 2020
@skabashnyuk skabashnyuk marked this pull request as ready for review October 20, 2020 11:31
@skabashnyuk
Copy link
Contributor Author

@sleshchenko @sparkoo I've reworked my pr. Please take a look.

@che-bot
Copy link
Contributor

che-bot commented Oct 20, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk skabashnyuk mentioned this pull request Oct 21, 2020
Closed
@skabashnyuk
Copy link
Contributor Author

depends on #18153

@skabashnyuk skabashnyuk added the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label Oct 21, 2020
@skabashnyuk
Merge remote-tracking branch 'upstream/master' into che18027
c25ecbc 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Oct 26, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@skabashnyuk
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Oct 26, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk skabashnyuk merged commit 525fa10 into eclipse-che:master Oct 27, 2020
@skabashnyuk skabashnyuk deleted the che18027 branch October 27, 2020 05:34
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko left review comments

@sparkoo sparkoo sparkoo approved these changes

@metlos metlos Awaiting requested review from metlos

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@amisevsk amisevsk Awaiting requested review from amisevsk

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to define workspace deployment labels
5 participants
@skabashnyuk @sparkoo @dmytro-ndp @che-bot @sleshchenko