FIX: Append gitconfig instead of override in GitCredentialStorageFileSecretApplier #17554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eSecretApplier Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
requested review from
amisevsk,
l0rd,
metlos,
nickboldt and
sleshchenko
as code owners
skabashnyuk
requested review from
sparkoo and
mshaposhnik
and removed request for
nickboldt,
l0rd,
sleshchenko and
amisevsk
che-bot
added
kind/bug
mshaposhnik
approved these changes
Aug 4, 2020
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
sparkoo
approved these changes
Aug 4, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FIX: Append gitconfig instead of override in GitCredentialStorageFileSecretApplier
What issues does this PR fix or reference?
GitCredentialStorageFileSecretApplier replaces the content of git-config instead of adding to it.
Release Notes
N/A
Docs PR
N/A