Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit dependabot configuration #17330

Merged
merged 9 commits into from
Jul 8, 2020
Merged

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Add explicit dependabot configuration

  • notifu about security updates
  • check java:maven from /
  • check Dockerfile from /dockerfiles/

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk skabashnyuk requested review from mshaposhnik, sparkoo, metlos and tolusha and removed request for l0rd July 3, 2020 13:07
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 3, 2020
@che-bot
Copy link
Contributor

che-bot commented Jul 3, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@benoitf
Copy link
Contributor

benoitf commented Jul 3, 2020

what about security alerts we have in https://github.com/eclipse/che/tree/master/tests ?

@skabashnyuk
Copy link
Contributor Author

what about security alerts we have in https://github.com/eclipse/che/tree/master/tests ?

@rhopp @dmytro-ndp what about security alerts we have in https://github.com/eclipse/che/tree/master/tests ?

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Jul 6, 2020

@skabashnyuk: the alert about improper minimist version https://github.com/eclipse/che/network/alert/tests/e2e/package-lock.json/minimist/open
But it's related to tests, not to product itself. So, it doesn't look as something dangerous for Eclipse Che, IMHO.

@Ohrimenko1988, @Katka92, @rhopp: WDYT about upgrading minimist version in our E2E typescript tests /e2e/package-lock.json to 0.2.1 version?

@benoitf
Copy link
Contributor

benoitf commented Jul 6, 2020

@dmytro-ndp FYI there is already an open PR #17297

@musienko-maxim
Copy link
Contributor

[ci-test]

@musienko-maxim
Copy link
Contributor

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jul 7, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@musienko-maxim
Copy link
Contributor

When i relaunch the happy path test during the maven build project we have error like:
16:29:08 [Build Che including upstream projects] [INFO] ------------------------------------------------------------------------ 16:29:08 [Build Che including upstream projects] [INFO] BUILD FAILURE 16:29:08 [Build Che including upstream projects] [INFO] ------------------------------------------------------------------------ 16:29:08 [Build Che including upstream projects] [INFO] Total time: 3.455 s 16:29:08 [Build Che including upstream projects] [INFO] Finished at: 2020-07-07T09:29:07-04:00 16:29:08 [Build Che including upstream projects] [INFO] ------------------------------------------------------------------------ 16:29:08 [Build Che including upstream projects] [ERROR] Failed to execute goal com.mycila:license-maven-plugin:3.0:check (check-headers) on project che-docs: Some files do not have the expected license header -> [Help 1] 16:29:08 [Build Che including upstream projects] [ERROR] 16:29:08 [Build Che including upstream projects] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. 16:29:08 [Build Che including upstream projects] [ERROR] Re-run Maven using the -X switch to enable full debug logging. 16:29:08 [Build Che including upstream projects] [ERROR] 16:29:08 [Build Che including upstream projects] [ERROR] For more information about the errors and possible solutions, please read the following articles: 16:29:08 [Build Che including upstream projects] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Please take a look on this

@che-bot
Copy link
Contributor

che-bot commented Jul 7, 2020

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jul 8, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jul 8, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk skabashnyuk merged commit 3ceb162 into eclipse-che:master Jul 8, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants