Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docker images instead of maven artifact to deliver che-dashboard && che-workspace-loader #16802

Merged
merged 1 commit into from
May 12, 2020
Merged

Use docker images instead of maven artifact to deliver che-dashboard && che-workspace-loader #16802

merged 1 commit into from
May 12, 2020

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Apr 29, 2020 •
edited
Loading

What does this PR do?

Use docker images instead of maven artifact to deliver che-dashboard && che-loader

What issues does this PR fix or reference?

#16799

Release Notes

n/a

Docs PR

n/a

@che-bot che-bot added kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Apr 29, 2020
@skabashnyuk skabashnyuk marked this pull request as ready for review May 6, 2020 10:34
@skabashnyuk skabashnyuk changed the title [WIP] Use docker images instead of maven artifact to deliver che-dashboard Use docker images instead of maven artifact to deliver che-dashboard May 6, 2020
@skabashnyuk skabashnyuk changed the title Use docker images instead of maven artifact to deliver che-dashboard [WIP] Use docker images instead of maven artifact to deliver che-dashboard && che-workspace-loader May 7, 2020
@skabashnyuk skabashnyuk changed the title [WIP] Use docker images instead of maven artifact to deliver che-dashboard && che-workspace-loader Use docker images instead of maven artifact to deliver che-dashboard && che-workspace-loader May 8, 2020
@skabashnyuk
Use docker images instead of maven artifact to deliver che-dashboard …
59746dd 
…&& che-workspace-loader

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented May 11, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@eclipse-che eclipse-che deleted a comment from che-bot May 11, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 11, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 11, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 11, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 11, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 11, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 11, 2020
nickboldt
nickboldt approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 based on BJN discussion.

@nickboldt
Copy link
Contributor

Note to me: once this is merged, the following build processes will need updating:

@skabashnyuk
Copy link
Contributor Author

PR for hosted che redhat-developer/rh-che#1890

@skabashnyuk skabashnyuk linked an issue May 12, 2020 that may be closed by this pull request
Use docker images instead of maven artifact to deliver che-dashboard and che-loader #16799
Closed
@skabashnyuk skabashnyuk merged commit f390060 into eclipse-che:master May 12, 2020
@skabashnyuk skabashnyuk deleted the che16799 branch May 12, 2020 16:56
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 12, 2020
Katka92 pushed a commit to Katka92/che that referenced this pull request May 14, 2020
@skabashnyuk @Katka92
Use docker images instead of maven artifact to deliver che-dashboard …
81587bd 
…&& che-workspace-loader (eclipse-che#16802)

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@benoitf benoitf added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuznyetsov mkuznyetsov mkuznyetsov left review comments

@nickboldt nickboldt nickboldt approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@metlos metlos Awaiting requested review from metlos

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@sparkoo sparkoo Awaiting requested review from sparkoo

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use docker images instead of maven artifact to deliver che-dashboard and che-loader
5 participants
@skabashnyuk @che-bot @nickboldt @mkuznyetsov @benoitf