Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metric] Total workspace count #16640

Merged
merged 7 commits into from
Apr 20, 2020
Merged

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Apr 17, 2020

What does this PR do?

Changes

  • add explicit methods to get total number of workspaces to WorkspaceManager WorkspaceDao MultiuserJpaWorkspaceDao JpaWorkspaceDao
  • Set grafana image version from upstream.
  • che_workspace_total or sum(che_workspace_status) used to display number of workspaces on the dashboard.

Знімок екрана 2020-04-17 о 14 20 31

What issues does this PR fix or reference?

Fixes #16465

Release Notes

n/a

Docs PR

n/a

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot che-bot added kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Apr 17, 2020
@che-bot
Copy link
Contributor

che-bot commented Apr 17, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk skabashnyuk marked this pull request as ready for review April 17, 2020 12:21
@skabashnyuk skabashnyuk requested review from sparkoo and ibuziuk and removed request for nickboldt, l0rd, rhopp and sleshchenko April 17, 2020 12:21
@che-bot
Copy link
Contributor

che-bot commented Apr 17, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Apr 20, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk skabashnyuk merged commit af4465f into eclipse-che:master Apr 20, 2020
@skabashnyuk skabashnyuk deleted the che16465 branch April 20, 2020 12:13
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metric] Total workspace count
5 participants