Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md with new location of dashboard and workspace loader #16430

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Update CONTRIBUTING.md with new location of dashboard and workspace loader

What issues does this PR fix or reference?

n/a

Release Notes

n/a

Docs PR

n/a

…oader

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot che-bot added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Mar 24, 2020
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@sparkoo
Copy link
Member

sparkoo commented Mar 24, 2020

Thanks for this. It's a big relief not to wait for sloooooow dashboard build. ❤️

@che-bot
Copy link
Contributor

che-bot commented Mar 24, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 24, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Mar 24, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my +1 to merge it as is, and then open separate issues to move corresponding parts of CONTRIBUTING.md to che-dashboard and che-workspace-loader repos.

@sunix
Copy link
Contributor

sunix commented Mar 24, 2020

created #16431 and #16432

@skabashnyuk skabashnyuk merged commit a92c8bf into eclipse-che:master Mar 24, 2020
@skabashnyuk skabashnyuk deleted the updatecontrib branch March 24, 2020 12:08
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants