Upgrade metrics and tracing dependencies#14923
Merged
skabashnyuk merged 4 commits intomasterfrom Oct 21, 2019
Merged
Conversation
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
requested review from
amisevsk,
l0rd,
metlos,
nickboldt,
rhopp,
sleshchenko and
vparfonov
as code owners
che-bot
added
status/code-review
Contributor
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Contributor
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
Contributor
Author
|
ci-test |
vparfonov
approved these changes
Oct 18, 2019
Contributor
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
metlos
reviewed
Oct 18, 2019
Contributor
metlos
left a comment
metlos
left a comment
There was a problem hiding this comment.
IMHO looks quite reasonable but I'd like to learn the reason for the explicit span.finish()
...main/java/org/eclipse/che/workspace/infrastructure/kubernetes/KubernetesInternalRuntime.java
Show resolved
Hide resolved
core/che-core-tracing-core/src/main/java/org/eclipse/che/core/tracing/TracingInterceptor.java
Outdated
Show resolved
Hide resolved
… Kabashniuk <skabashniuk@redhat.com> Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Contributor
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
amisevsk
approved these changes
Oct 18, 2019
core/che-core-tracing-core/src/main/java/org/eclipse/che/core/tracing/TracingInterceptor.java
Show resolved
Hide resolved
Contributor
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
Contributor
Author
|
@metlos are you ok with this pr? Can I merge it? |
metlos
approved these changes
Oct 21, 2019
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Contributor
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
Contributor
Author
|
ci-test |
Contributor
Author
|
crw-ci-test |
Contributor
Author
|
ci-build |
3 tasks
Contributor
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
Contributor
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
che-bot
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade metrics and tracing dependencies.
This is a subset of #14727 pr. I've decided to move the upgrade of dependencies to the separate to make review process is easier.
Major changes are related to changes in tracing api. Related to eclipse-che/che-parent#133
What issues does this PR fix or reference?
#14601
Release Notes
n/a
Docs PR
n/a