Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factory URL: devfile.yaml is not detected if the default branch is not master #18116

Closed
1 of 3 tasks
sunix opened this issue Oct 15, 2020 · 2 comments
Closed
1 of 3 tasks

Factory URL: devfile.yaml is not detected if the default branch is not master #18116

sunix opened this issue Oct 15, 2020 · 2 comments
Labels
area/factory/server Server side of factory implementation good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented Oct 15, 2020 •
edited
Loading

Describe the bug

For Github projects, when using https://<che-host>/factory?url=https://github.com/sunix/scratch-gui where scratch-gui has the a default branch develop and not master, Che factory can't find the devfile.yaml that is located in the root folder of the project in the default branch develop.
This is important to fix having that we will have less and less default branch called master in the near futur.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

Expected behavior

Should load the devfile and clone the 3 repos + include all the components and commands defined in the devfile
@sunix sunix added kind/bug Outline of a bug - must adhere to the bug report template. area/factory/server Server side of factory implementation labels Oct 15, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 15, 2020
@sunix sunix mentioned this issue Oct 15, 2020
Closed
@sunix sunix added severity/P1 Has a major impact to usage or development of the system. good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 15, 2020
@azatsarynnyy
Copy link
Member

It seems a duplicate of #18044 that was fixed by #18066

@sunix
Copy link
Contributor Author

sunix commented Oct 15, 2020

ok I am closing for now

@sunix sunix closed this as completed Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/factory/server Server side of factory implementation good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sunix @azatsarynnyy @che-bot