Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support raw devfile urls without yaml extension #683

Merged
merged 5 commits into from
May 15, 2024
Merged

Support raw devfile urls without yaml extension #683

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a509dd5
Support raw devfile urls without yaml extension
vinokurig May 9, 2024
ec3ee70
Update wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/ap…
vinokurig May 9, 2024
ba0faa9
fixup! Support raw devfile urls without yaml extension
vinokurig May 9, 2024
58cc77f
fixup! Support raw devfile urls without yaml extension
vinokurig May 13, 2024
974595e
fixup! Support raw devfile urls without yaml extension
vinokurig May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/ap… 
…i/factory/server/RawDevfileUrlFactoryParameterResolver.java

Co-authored-by: Anatolii Bazko <abazko@redhat.com>
  • Loading branch information
@vinokurig @tolusha
vinokurig and tolusha committed May 9, 2024
commit ec3ee70f50dd3de4533567e8df1e18e6d378d5d2
2 changes: 1 addition & 1 deletion ...c/main/java/org/eclipse/che/api/factory/server/RawDevfileUrlFactoryParameterResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public RawDevfileUrlFactoryParameterResolver(
@Override
public boolean accept(Map<String, String> factoryParameters) {
String url = factoryParameters.get(URL_PARAMETER_NAME);
return !isNullOrEmpty(url) && PATTERN.matcher(url).matches() || containsDevfile(url);
return !isNullOrEmpty(url) && (PATTERN.matcher(url).matches() || containsDevfile(url));
}

private boolean containsDevfile(String requestURL) {
Expand Down
Loading