-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically perform a backup of Che server side components before attempting an upgrade #1055
Conversation
3a79055
to
ecea819
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have some unit tests for this new feature.
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
- Coverage 52.52% 52.19% -0.33%
==========================================
Files 62 63 +1
Lines 7688 7757 +69
==========================================
+ Hits 4038 4049 +11
- Misses 3215 3271 +56
- Partials 435 437 +2
Continue to review full report at Codecov.
|
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Makes Che Operator to create a backup of Che installation before upgrading it to newer version.
As operator cannot know when it will be replaced with a newer version, it is the newer operator that does the backup before updating Che to newer version. The backup is sent to internal backup server to have the behavior more predictable (and to not to guess in case several backup servers configured). Backup CRs are named after version to upgrade to:
backup-before-update-to-<version>
(for example:backup-before-update-to-7-36-2
). Also, to be able to know the version of the operator needed to reastore the backup,cheVersion
field is added to the backup CRD status.Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Is a part of https://issues.redhat.com/browse/CRW-1497
How to test this PR?
./bundle/stable/eclipse-che-preview-openshift/manifests/che-operator.clusterserviceversion.yaml
../olm/testUpdate.sh
script tillwaitCheServerDeploy
line (it should deploy the catalog source built in previous step)PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Release Notes Text
Server component backup of the Che server has been introduced a few releases ago. Now it’s performed automatically before every Che upgrade.