-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix validation errors and warnings #2766
Conversation
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
🎊 Navigate the preview: https://66b4ce52fb30ed009b68de11--eclipse-che-docs-pr.netlify.app 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
another fixup commit pushed to fix the remaining warning
|
* fix validation errors and warnings Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * fixup! fix validation errors and warnings --------- Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
What does this pull request change?
Address errors that happen during the build and validate stage:
For some reason, antora build incorrectly replaces
[discrete]
tag with[discret#administration-guide:creating-a-telemetry-plugin:::_creating_a_server_that_receives_eventse]
. breaking apart the tag at the last character. For now, we could remove the heading, while the cause of this issue is still being determinedmost of these warnings could be fixed by moving around admonition / delimiter blocks, removing
+
linebreaksit appears that there are simply two same ids, that was fixed by changing one of them to match the title
What issues does this pull request fix or reference?
eclipse-che/che#23020
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.