Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revoking of Git service tokens #1065

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix revoking of Git service tokens #1065

merged 1 commit into from
Mar 20, 2024

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR fixes two bugs related to revoking tokens on the Git Services page:

What issues does this PR fix or reference?

fix eclipse-che/che#22827
fix eclipse-che/che#22790

Is it tested? How?

See the screencasts above.

@akurinnoy akurinnoy self-assigned this Mar 8, 2024
@che-bot
Copy link
Contributor

che-bot commented Mar 8, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Mar 8, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1065

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1065", name: che-dashboard}]}}]"

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 99.22481% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.11%. Comparing base (12a6f21) to head (2f219d6).

Files Patch % Lines
...shboard-frontend/src/store/GitOauthConfig/index.ts 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
+ Coverage   88.92%   89.11%   +0.18%     
==========================================
  Files         396      397       +1     
  Lines       40505    40557      +52     
  Branches     2737     2735       -2     
==========================================
+ Hits        36021    36141     +120     
+ Misses       4458     4390      -68     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Знімок екрана 2024-03-11 о 16 29 49

@artaleks9
Copy link
Contributor

Verified on Eclipse Che with quay.io/eclipse/che-dashboard:pr-1065 - works properly

Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, artaleks9, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Copy link

openshift-ci bot commented Mar 18, 2024

New changes are detected. LGTM label has been removed.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1065

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1065", name: che-dashboard}]}}]"

@artaleks9
Copy link
Contributor

artaleks9 commented Mar 18, 2024

@akurinnoy @vinokurig
on bitucket-server-oauth2, I faced out with the git service Authorization is still active after revoke application

Screenshot:
che-bb-server-oauth2-authorization

Video:

pr-1065.-bb-server-oauth2.mp4

I'll verify gitlab-server to have all checks

@artaleks9
Copy link
Contributor

artaleks9 commented Mar 18, 2024

The functionality of gitlab-server works as expected
Also the functionality of bitbucket-server-oauth1 works as expected

@vinokurig
Copy link
Contributor

@artaleks9

on bitucket-server-oauth2, I faced out with the git service Authorization is still active after revoke application

Reopened the related issue: eclipse-che/che#22836

@akurinnoy akurinnoy merged commit 3008a37 into main Mar 20, 2024
18 checks passed
@akurinnoy akurinnoy deleted the fix-revoke-button branch March 20, 2024 09:13
@devstudio-release
Copy link

Build 3.13 :: dashboard_3.x/461: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.13 :: dashboard_3.x/461: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6286 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.13 :: copyIIBsToQuay/2552: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.13 :: sync-to-downstream_3.x/6288: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6250 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.13 :: operator-bundle_3.x/2684: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6288 triggered

@devstudio-release
Copy link

Build 3.13 :: update-digests_3.x/6106: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2684 triggered

@devstudio-release
Copy link

Build 3.13 :: dsc_3.x/1835: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.13 :: dsc_3.x/1835: SUCCESS

3.13.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants