-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix revoking of Git service tokens #1065
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1065 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1065", name: che-dashboard}]}}]" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
+ Coverage 88.92% 89.11% +0.18%
==========================================
Files 396 397 +1
Lines 40505 40557 +52
Branches 2737 2735 -2
==========================================
+ Hits 36021 36141 +120
+ Misses 4458 4390 -68
Partials 26 26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified on Eclipse Che with |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
1a8ca4b
to
2f219d6
Compare
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1065 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1065", name: che-dashboard}]}}]" |
@akurinnoy @vinokurig Video: pr-1065.-bb-server-oauth2.mp4I'll verify gitlab-server to have all checks |
The functionality of |
Reopened the related issue: eclipse-che/che#22836 |
Build 3.13 :: dashboard_3.x/461: Console, Changes, Git Data |
Build 3.13 :: sync-to-downstream_3.x/6286: Console, Changes, Git Data |
Build 3.13 :: push-latest-container-to-quay_3.x/4407: Console, Changes, Git Data |
Build 3.13 :: get-sources-rhpkg-container-build_3.x/6248: dashboard : 3.x :: Build 59872116 : quay.io/devspaces/dashboard-rhel8:3.13-10 |
Build 3.13 :: dashboard_3.x/461: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6286 triggered |
Build 3.13 :: update-digests_3.x/6106: Console, Changes, Git Data |
Build 3.13 :: operator-bundle_3.x/2684: Console, Changes, Git Data |
Build 3.13 :: sync-to-downstream_3.x/6288: Console, Changes, Git Data |
Build 3.13 :: push-latest-container-to-quay_3.x/4408: Console, Changes, Git Data |
Build 3.13 :: copyIIBsToQuay/2552: Console, Changes, Git Data |
Build 3.13 :: sync-to-downstream_3.x/6288: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6250 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.13 :: operator-bundle_3.x/2684: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6288 triggered |
Build 3.13 :: update-digests_3.x/6106: Detected new images: rebuild operator-bundle |
Build 3.13 :: dsc_3.x/1835: Console, Changes, Git Data |
Build 3.13 :: dsc_3.x/1835: 3.13.0-CI |
What does this PR do?
This PR fixes two bugs related to revoking tokens on the Git Services page:
the Revoke button becomes disabled after revoking the selected git service token (Revoke OAuth button still in active state after OAuth revoked che#22827);
demo 1
Screen.Recording.2024-03-08.at.16.53.32.mov
switching between tabs doesn't prevent revoking the git service token (Revoke git service action is available after apply che#22790).
demo 2
Screen.Recording.2024-03-08.at.16.57.11.mov
What issues does this PR fix or reference?
fix eclipse-che/che#22827
fix eclipse-che/che#22790
Is it tested? How?
See the screencasts above.