-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search capabilities to Peripheral Inspector view #25
base: main
Are you sure you want to change the base?
Add search capabilities to Peripheral Inspector view #25
Conversation
- Provide custom SearchOverlay component - Add search overlay to filter tree and tree table - Move custom data into the 'data' for filtering in tree table Closes eclipse-cdt-cloud#23
1cb8105
to
0fb6d4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some functional findings
- Nit: If the search filter causes the vertical scrollbar to disappear, then the find field "jumps" to the right. Feels a little noisy, but maybe something users can live with for now.
- Nit: When I expand/collapse a group, then I see a progress line at the top of the view. But no DAP requests (I assume it's supposed to cover delays caused by target accesses). Need to double-check if that was there before this PR/the PrimeReact introduction.
- Search only searches through visible items (and presumably previously expanded children). But we may also want to search through not yet visited items. Exploring the register tree by "random" keywords could be a powerful side effect of this feature. Is this where you hit performance issues?
@@ -25,12 +27,14 @@ export type ComponentTreeProps = { | |||
|
|||
const PROGRESS_BAR_HIDE_DELAY = 200; | |||
|
|||
export const ComponentTree = (props: ComponentTreeProps) => { | |||
export const ComponentTree = ({ nodes, selectedNode, isLoading }: ComponentTreeProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: expanding the properties here is inconsistent with other components in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I prefer deconstructing properties as it makes the code more readable in my opinion. I agree, however, that we should stay consistent and for the purpose of this PR I changed it back to accessing props directly.
@jreineckearm I pushed an update that should address your comments. The only thing I couldn't reproduce was the filtering purely based on visible items. Could you provide an example of where that is happening? |
Closes #23