Fix parsing of sampling to match tsp specification#144
Merged
bhufmann merged 2 commits intoeclipse-cdt-cloud:masterfrom Oct 17, 2025
Merged
Fix parsing of sampling to match tsp specification#144bhufmann merged 2 commits intoeclipse-cdt-cloud:masterfrom
bhufmann merged 2 commits intoeclipse-cdt-cloud:masterfrom
Conversation
The server was modified to comply to tsp specification for sampling, update accordingly here. Signed-off-by: Siwei Zhang <siwei.zhang@ericsson.com>
Merged
1 task
PatrickTasse
requested changes
Oct 16, 2025
| import { QueryHelper } from '../models/query/query-helper'; | ||
| import { isAxisDomainCategorical, isAxisDomainRange } from '../models/axis-domain'; | ||
| import { StartEndRange } from '../models/sampling'; | ||
| // import { Range } from '../models/sampling'; |
The server was modified to comply to tsp specification for sampling, update accordingly here. There are now 3 different arrays for x values: xValues (legacy xy for timestamps), xCategories (array of string) and xRanges (array of StartEndRanges). Note that StartEndRange is now an object with start and end attributes. Before it was an array with 2 values. Contributes to fix: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#236 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
PatrickTasse
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server was modified to comply to tsp specification for sampling, update accordingly here.
What it does
Update
Samplingto match the updated server response in:eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#238Related issue: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#236
How to test
yarn test --verbose
Follow-ups
No follow-ups.
Review checklist