Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADRs about updating of experiments as part of the TSP #688

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

bhufmann
Copy link
Collaborator

Contributes to #608

Signed-off-by: Bernd Hufmann Bernd.Hufmann@ericsson.com

@marco-miller marco-miller self-requested a review February 23, 2022 22:36
@bhufmann
Copy link
Collaborator Author

I updated the PR to have one ADR for update the experiment which focuses on the parameters passed when creating the experiment, i.e. name and list of trace UUIDs. Other updates won't not part of this PR. They need dedicated investigations and ADRs.

@bhufmann bhufmann marked this pull request as ready for review March 22, 2022 14:13
Copy link
Contributor

@marco-miller marco-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

marco-miller
marco-miller previously approved these changes Mar 25, 2022
Copy link
Contributor

@marco-miller marco-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

doc/adr/0005-tsp-update-experiment.md Outdated Show resolved Hide resolved
doc/adr/0005-tsp-update-experiment.md Outdated Show resolved Hide resolved
doc/adr/0005-tsp-update-experiment.md Outdated Show resolved Hide resolved
Contributes to eclipse-cdt-cloud#608

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Copy link
Contributor

@marco-miller marco-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@bhufmann bhufmann merged commit bc85069 into eclipse-cdt-cloud:master Mar 29, 2022
@bhufmann bhufmann deleted the update-experiment-adr branch March 29, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants