Theia release 1.50 #1087
Closed
Theia release 1.50 #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
force-pushed
the
theia-release-1.50
branch
from
3183645
to
4e7aebc
Compare
marcdumais-work
force-pushed
the
theia-release-1.50
branch
from
702959f
to
ef63b99
Compare
|
ATM the electron rebuilds fails, when rebuilding the native dependencies. Forcing dependency "nan" to "2.18.0", in the main package.json, seems to resolve the problem:
|
Thanks for finding the fix. As you mentioned, mainline Theia also applied this. I tested it and it works. I'll update this PR so that we have available when doing the next upgrade. |
Update nan version to fix the Electron build. Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
theia-release-1.50
branch
from
41bdc26
to
e82a677
Compare
|
I think we do not need this PR anymore, having skipped over Theia 1.50.0 and gone directly to 1.52.0. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com