Silently pause target before reset if running #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Remove step used to test if my expectations around step while running for various modes is true. Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
jreineckearm
changed the title
jreineckearm
force-pushed
the
reset-while-running
branch
from
0e7df9a to
330e276
Compare
thorstendb-ARM
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #463
pauseIfNeededbefore callingcustomResetCommands.pauseCounterif > 0 after that. We do not want to automatically set the target running after the reset (or callcontinueIfNeeded) unless the commands do that. Even if it was running when pressing the reset button. This is to have a somewhat well-defined behavior. See issue description. The decrement is necessary to avoid breaking the logic the next time it is called in a different context.