Add threadId and FrameId as optional parameters #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyoTwT
force-pushed
the
tt_add_thread_frame
branch
from
5a4c4a9 to
225072f
Compare
The future needs to read/write memory on a thread basis requires the GDB MI commands to be updated. The GDB MI commands can take a threadId and frameId if specified so add that capability as an optional parameter. Add unit test to verify threadId and frameId changes. Multithread test is needed to showcase this change.
WyoTwT
force-pushed
the
tt_add_thread_frame
branch
from
225072f to
958ad91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GDB MI commands can take a
threadIdandframeIdif specified so add that capability as an optional parameter to support future thread-specific functionality.