Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run licensecheck #424

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Run licensecheck #424

merged 1 commit into from
Mar 11, 2024

Conversation

akurtakov
Copy link
Contributor

No description provided.

@akurtakov
Copy link
Contributor Author

Licensecheck fails to start with https://github.com/eclipse-cbi/org.eclipse.cbi/actions/runs/8230419948 . @mbarbero @fredg02 should this one be allowed? I would say yes as dash-licenses uses it by default.

@fredg02
Copy link
Contributor

fredg02 commented Mar 11, 2024

@akurtakov AFAICT there has been no HelpDesk issue requesting the setup of the license vetting workflow for the CBI project, so far. Can you open one?

@akurtakov
Copy link
Contributor Author

Here you are https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4416

@fredg02 fredg02 merged commit 91a4d2e into eclipse-cbi:main Mar 11, 2024
6 checks passed
@akurtakov
Copy link
Contributor Author

@fredg02 It still doesn't run licensecheck as can be seen at https://github.com/eclipse-cbi/org.eclipse.cbi/actions/runs/8237852312 . There must be some org or repo config allowing only given set of GH actions.

@akurtakov
Copy link
Contributor Author

@netomi
Copy link
Contributor

netomi commented Mar 11, 2024

can be enabled via self-service.

@netomi
Copy link
Contributor

netomi commented Mar 11, 2024

running octopin I get the following list of actions:

/home/tn/workspace/eclipse/eclipse-cbi/org.eclipse.cbi/.github/workflows/licensecheck.yml
└── eclipse/dash-licenses/.github/workflows/mavenLicenseCheck.yml@master
    ├── actions/cache@v4
    ├── actions/checkout@v4
    ├── actions/checkout@v4
    ├── actions/github-script@v7
    ├── actions/github-script@v7
    ├── actions/setup-java@v4
    ├── actions/upload-artifact@v4
    ├── eclipse/dash-licenses/.github/actions/maven-license-check-action@master
    └── stCarolas/setup-maven@v5

@netomi
Copy link
Contributor

netomi commented Mar 11, 2024

Created eclipse-cbi/.eclipsefdn#11

@netomi
Copy link
Contributor

netomi commented Mar 11, 2024

should work now.

@fredg02
Copy link
Contributor

fredg02 commented Mar 11, 2024

@fredg02
Copy link
Contributor

fredg02 commented Mar 12, 2024

@akurtakov please test if it works as expected now.

@akurtakov
Copy link
Contributor Author

/request-license-review on #425 did nothing so I guess I screwed smth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants