Skip to content

Fixes rollup config for bundling #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Fixes rollup config for bundling #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c13796
Fixes roolup config for bundling
aaronzi Feb 7, 2025
e1d44b0
Adds bundle directory to eslint ignores
aaronzi Feb 7, 2025
021e173
Ignores bundle directory in prettier and jest
aaronzi Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Ignore build output directories
build/
dist/
bundle/

# Ignore node modules
node_modules/
Expand Down
2 changes: 1 addition & 1 deletion eslint.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import ts from 'typescript-eslint';

export default [
{
ignores: ['node_modules', 'dist', 'src/generated'],
ignores: ['node_modules', 'dist', 'src/generated', 'bundle'],
},

{
Expand Down
2 changes: 1 addition & 1 deletion jest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ module.exports = {
coverageDirectory: 'coverage',
coverageReporters: ['json', 'lcov', 'text', 'clover'],
coveragePathIgnorePatterns: ['<rootDir>/src/generated/'],
testPathIgnorePatterns: ['<rootDir>/dist/', '<rootDir>/node_modules/'],
testPathIgnorePatterns: ['<rootDir>/dist/', '<rootDir>/node_modules/', '<rootDir>/bundle/'],
};
3 changes: 1 addition & 2 deletions rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ export default {
input: 'dist/index.js',
output: {
file: 'bundle/index.js',
format: 'cjs', // CommonJS module format
format: 'esm',
sourcemap: true,
exports: 'named',
},
plugins: [
resolve(), // helps Rollup find node_modules packages
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "ES6",
"target": "ESNext",
"module": "NodeNext",
"moduleResolution": "nodenext",
"declaration": true,
Expand Down