[eclipse/xtext-xtend#149] allow extension fields in java 8 interfaces #865
Conversation
| IFeatureScopeSession result = featureScopeSession; | ||
| if (superType != null) { | ||
| result = addExtensionFieldsToMemberSession(resolvedTypes, featureScopeSession, (JvmDeclaredType) superType.getType(), thisFeature, seenNames, seenTypes); | ||
| for (JvmTypeReference ifx : type.getSuperTypes()) { |
There was a problem hiding this comment.
is there a better way? do we need sorting?
There was a problem hiding this comment.
Yes, we'll need some sorting here to get a stable or understandable precedence. Now that we have to consider a graph due to multiple interface inheritance and also need to support duplicates that are allowed in that graph (following the superclass alone would only ever see dups for invalid hierarchies), a predictable order must be used.
org.eclipse.xtext.xbase.typesystem.override.ResolvedFeatures.computeAllOperationsFromSortedSuperTypes(JvmDeclaredType, Multimap<String, AbstractResolvedOperation>) might be a good starting point.
There was a problem hiding this comment.
arggg guess ill postpone until i find time to digg into
cdietrich
force-pushed
the
cd_issue149
branch
from
77806bb to
d65bad7
Compare
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
cdietrich
force-pushed
the
cd_issue149
branch
from
d65bad7 to
506497f
Compare
|
replaced with eclipse-xtext/xtext#2591 |
[eclipse-xtext/xtext#2259] allow extension fields in java 8 interfaces