Externalize User Facing Strings for application plugin #2026#2148
Open
sshekhar-04 wants to merge 1 commit intoeclipse-4diac:developfrom
Open
Externalize User Facing Strings for application plugin #2026#2148sshekhar-04 wants to merge 1 commit intoeclipse-4diac:developfrom
sshekhar-04 wants to merge 1 commit intoeclipse-4diac:developfrom
Conversation
Extracted all user-facing strings from the application plugin into plugin.properties. This is the largest plugin in the IDE. I have verified that internal identifiers and command parameters remain hardcoded. Part of eclipse-4diac#2026 Signed-off-by: sshekhar-04 <shreyanshsd512gb@gmail.com>
Test Results 110 files ±0 110 suites ±0 1m 10s ⏱️ -2s Results for commit eaf04fb. ± Comparison against base commit 4008848. This pull request removes 73 and adds 73 tests. Note that renamed tests count towards both. |
azoitl
requested changes
Feb 18, 2026
Contributor
azoitl
left a comment
There was a problem hiding this comment.
can you please remove the application prefix. it adds complexity that is not needed, makes it harder for translators and reduces maintainability if these entries are moved to different locations.
Please also reconsider the names of the strings starting with jdt...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2026
This PR addresses the externalization of user-facing strings for the
org.eclipse.fordiac.ide.applicationplugin. As this is one of the largest and most critical plugins in the IDE, I have performed a thorough review of theplugin.xmlto ensure a clean separation between translatable labels and internal technical identifiers.Key Changes:
Bundle-Localization: pluginheader to theMANIFEST.MF.name,label, anddescriptionattributes for views, menus, and commands.plugin.propertiesusing theapplication.*namespace for better organization.id,commandId,parameter name/value, andcategory, remain hardcoded to prevent any regression in functional logic.@azoitl , since this is the largest plugin, I have double-checked the diff to ensure no closing tags were accidentally altered. With this submission, I believe the main objectives of #2026 have been met. Please let me know if there are any further plugins you would like me to address.
Part of #2026