Skip to content

Comments

Externalize User Facing Strings for application plugin #2026#2148

Open
sshekhar-04 wants to merge 1 commit intoeclipse-4diac:developfrom
sshekhar-04:feature/2026-i18n-application
Open

Externalize User Facing Strings for application plugin #2026#2148
sshekhar-04 wants to merge 1 commit intoeclipse-4diac:developfrom
sshekhar-04:feature/2026-i18n-application

Conversation

@sshekhar-04
Copy link
Contributor

@sshekhar-04 sshekhar-04 commented Feb 17, 2026

Part of #2026

This PR addresses the externalization of user-facing strings for the org.eclipse.fordiac.ide.application plugin. As this is one of the largest and most critical plugins in the IDE, I have performed a thorough review of the plugin.xml to ensure a clean separation between translatable labels and internal technical identifiers.

Key Changes:

  • Internationalization Setup: Added the Bundle-Localization: plugin header to the MANIFEST.MF.
  • UI Strings: Externalized all user-facing name, label, and description attributes for views, menus, and commands.
  • Properties Management: Created a comprehensive plugin.properties using the application.* namespace for better organization.
  • Internal Safety: Verified that all internal identifiers, such as id, commandId, parameter name/value, and category, remain hardcoded to prevent any regression in functional logic.

@azoitl , since this is the largest plugin, I have double-checked the diff to ensure no closing tags were accidentally altered. With this submission, I believe the main objectives of #2026 have been met. Please let me know if there are any further plugins you would like me to address.

Part of #2026

Extracted all user-facing strings from the application plugin into plugin.properties.

This is the largest plugin in the IDE. I have verified that internal identifiers and command parameters remain hardcoded.

Part of eclipse-4diac#2026

Signed-off-by: sshekhar-04 <shreyanshsd512gb@gmail.com>
@github-actions
Copy link

Test Results

  110 files  ±0    110 suites  ±0   1m 10s ⏱️ -2s
6 125 tests ±0  6 125 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 126 runs  ±0  6 126 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit eaf04fb. ± Comparison against base commit 4008848.

This pull request removes 73 and adds 73 tests. Note that renamed tests count towards both.
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[13] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "''", ""
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[14] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "'abc'", "abc"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[15] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "'17$C2$B0C'", "17°C"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[16] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "'21 $E2$82$AC'", "21 €"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[17] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "'a $F0$9F$AF$85-figure'", "a \U0001fbc5-figure"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[18] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "'4diac$'IDE'", "4diac'IDE"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[19] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "'4diac\"IDE'", "4diac\"IDE"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[20] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "'4diac$$IDE'", "4diac$IDE"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[21] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "'4diac$LIDE'", "4diac\\nIDE"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[22] org.eclipse.fordiac.ide.model.value.StringValueConverter@6dc7b7f, "'4diac$P$R$TIDE'", "4diac\\f\\r\\tIDE"
…
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[13] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "''", ""
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[14] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "'abc'", "abc"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[15] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "'17$C2$B0C'", "17°C"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[16] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "'21 $E2$82$AC'", "21 €"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[17] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "'a $F0$9F$AF$85-figure'", "a \U0001fbc5-figure"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[18] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "'4diac$'IDE'", "4diac'IDE"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[19] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "'4diac\"IDE'", "4diac\"IDE"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[20] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "'4diac$$IDE'", "4diac$IDE"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[21] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "'4diac$LIDE'", "4diac\\nIDE"
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[22] org.eclipse.fordiac.ide.model.value.StringValueConverter@623ed5ed, "'4diac$P$R$TIDE'", "4diac\\f\\r\\tIDE"
…

Copy link
Contributor

@azoitl azoitl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove the application prefix. it adds complexity that is not needed, makes it harder for translators and reduces maintainability if these entries are moved to different locations.

Please also reconsider the names of the strings starting with jdt...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants