This repository was archived by the owner on Mar 8, 2023. It is now read-only.
Updated python-pip to python2-pip for RedHat 7 variants #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea what I can do to help get the tests working? |
|
It seems to be a problem with ruby 1.9 and the version of metadata-lint gem. |
|
Ok, the problem solved in this issue voxpupuli/metadata-json-lint#74 . so we can wait for the next version 1.2.3 of the gem or just dropo support for ruby < 2 at all. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 7.3 appears to be looking for python2-pip instead of just python-pip. I've updated the params.pp to support that.
Please let me know the correct way to fix the spec tests for ensuring that RedHat 7 should use python2-pip while others should use python-pip. I'm sure the way I changed graphite_install_spec.rb is incorrect and there could be a better way.
Thanks!