Fix for #329 in echocat/puppet-graphite

[arymkus]

PR to incorporate previously published patch which generates proper config for carbon-cache instances.
See #329 for more details.

[arymkus]

@dwerder BTW, I'll have some spare time next week and can fix linter-related warnings.
Please reply if you want me to do it (in scope of this PR or can create new).

[dwerder]

That would be nice.

[arymkus]

Done.

[dwerder]

my only question is, why you want to set the pidfile in the carbon.conf, because it is already set in each init file. And the path is: scope.lookupvar('graphite::storage_dir_REAL')

https://github.com/echocat/puppet-graphite/blob/master/templates/etc/init.d/RedHat/carbon-cache.erb#L25

[arymkus]

Because carbon itself has ignored the higher scope's PATH variable in it's config and still stored it's .pid files in /var/run/... (or wherever the dafault path is) but the properly generated systemd's unit files contained new path to .pid files.
So the final behavior was - systemd starts carbon (and it was running well) but wasn't able to read actual carbon's .pid file and marked the service as failed. That was leading to manifest's failure.

[dwerder]

This has to be scope.lookupvar('graphite::storage_dir_REAL') to match the init scripts.

[arymkus]

in case of either storage_dir or whisper_dir param used - carbon creates its .pid files in correct place.
And only with local_data_dir carbon ignored proper location.
I've tested my fix and it works.

[arymkus]

ping