Run all tests in a suite in a single script. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to set and persist shell vars between commands.
echlebek
reviewed
Feb 27, 2022
internal/grill/runner.go
Outdated
| @@ -12,6 +13,9 @@ import ( | |||
| "syscall" | |||
| ) | |||
|
|
|||
| // Token used to separate output of individual commands in a suite. | |||
| const testBreak = "__GRILL__" | |||
There was a problem hiding this comment.
Seems fragile, shouldn't it work by keeping track of indices?
There was a problem hiding this comment.
I can't think of how it would work because each test command may output more or less lines than what's expected. Cram uses similar line splits but with the addition of random salt, which I'm guessing is intended to minimize the chance of the separator occurring unintentionally in the test spec. I can add the same here.
There was a problem hiding this comment.
OK, sounds like a good compromise.
echlebek
approved these changes
Feb 28, 2022
internal/grill/runner.go
Outdated
Comment on lines
229
to
240
| const digits = "0123456789" | ||
|
|
||
| // makeTestBreak generates a randomized line used to separate output of | ||
| // individual commands in a suite. Randomized element is added to reduce | ||
| // the change of the string occurring in the test output itself. | ||
| func makeTestBreak() string { | ||
| b := make([]byte, 8) | ||
| for i := range b { | ||
| b[i] = digits[rand.Intn(len(digits))] | ||
| } | ||
| return "GRILL" + string(b) + ":" | ||
| } |
There was a problem hiding this comment.
This is fine, but you can also do this fwiw
b := make([]byte, 8)
rand.Read(b)
return hex.EncodeToString(b)
There was a problem hiding this comment.
Much nicer; fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set and persist shell vars between commands.