feat(statusline)!: do not change laststatus = 3 to laststatus = 2

Resolve #1120

CHANGELOG.md

@@ -52,6 +52,7 @@
 ## mini.statusline
 
 - BREAKING FEATURE: update `section_fileinfo()` to show non-empty filetype even in not normal buffers (like plugin's scratch buffers, help, quickfix, etc.). Previously it showed nothing, which was a mistake as filetype can be a valuable information.
+- BREAKING FEATURE: the default `set_vim_settings` config value now does not affect `laststatus = 3` (aka global statusline).
 - FEATURE: prefer using 'mini.icons' as icon provider for `section_fileinfo()`.
 
 ## mini.surround

doc/mini-statusline.txt

@@ -150,9 +150,7 @@ Default values:
     -- Whether to use icons by default
     use_icons = true,
 
-    -- Whether to set Vim's settings for statusline (make it always shown with
-    -- 'laststatus' set to 2).
-    -- To use global statusline, set this to `false` and 'laststatus' to 3.
+    -- Whether to set Vim's settings for statusline (make it always shown)
     set_vim_settings = true,
   }
 <

lua/mini/statusline.lua

@@ -168,9 +168,7 @@ MiniStatusline.config = {
   -- Whether to use icons by default
   use_icons = true,
 
-  -- Whether to set Vim's settings for statusline (make it always shown with
-  -- 'laststatus' set to 2).
-  -- To use global statusline, set this to `false` and 'laststatus' to 3.
+  -- Whether to set Vim's settings for statusline (make it always shown)
   set_vim_settings = true,
 }
 --minidoc_afterlines_end
@@ -510,7 +508,7 @@ H.apply_config = function(config)
   MiniStatusline.config = config
 
   -- Set settings to ensure statusline is displayed properly
-  if config.set_vim_settings then vim.o.laststatus = 2 end
+  if config.set_vim_settings and (vim.o.laststatus == 0 or vim.o.laststatus == 1) then vim.o.laststatus = 2 end
 
   -- Ensure proper 'statusline' values (to not rely on autocommands trigger)
   H.ensure_content()

readmes/mini-statusline.md

@@ -157,9 +157,7 @@ Here are code snippets for some common installation methods (use only one):
   -- Whether to use icons by default
   use_icons = true,
 
-  -- Whether to set Vim's settings for statusline (make it always shown with
-  -- 'laststatus' set to 2).
-  -- To use global statusline, set this to `false` and 'laststatus' to 3.
+  -- Whether to set Vim's settings for statusline (make it always shown)
   set_vim_settings = true,
 }
 ```

tests/test_statusline.lua

@@ -154,8 +154,16 @@ T['setup()']['sets proper autocommands'] = function()
 end
 
 T['setup()']['respects `config.set_vim_settings`'] = function()
-  reload_module({ set_vim_settings = true })
-  eq(child.o.laststatus, 2)
+  local validate = function(init_laststatus, ref_laststatus)
+    child.o.laststatus = init_laststatus
+    reload_module({ set_vim_settings = true })
+    eq(child.o.laststatus, ref_laststatus)
+  end
+
+  validate(0, 2)
+  validate(1, 2)
+  validate(2, 2)
+  validate(3, 3)
 end
 
 T['setup()']['disables built-in statusline in quickfix window'] = function()