test(ALL): stop using mark_flaky() helper

tests/helpers.lua

@@ -162,13 +162,6 @@ Helpers.new_child_neovim = function()
   return child
 end
 
--- Mark test failure as "flaky"
-Helpers.mark_flaky = function()
-  MiniTest.finally(function()
-    if #MiniTest.current.case.exec.fails > 0 then MiniTest.add_note('This test is flaky.') end
-  end)
-end
-
 -- Detect CI
 Helpers.is_ci = function() return os.getenv('CI') ~= nil end
 Helpers.skip_in_ci = function(msg)

tests/test_indentscope.lua

@@ -3,7 +3,6 @@ local helpers = dofile('tests/helpers.lua')
 local child = helpers.new_child_neovim()
 local expect, eq = helpers.expect, helpers.expect.equality
 local new_set = MiniTest.new_set
-local mark_flaky = helpers.mark_flaky
 
 -- Helpers with child processes
 --stylua: ignore start
@@ -389,8 +388,6 @@ T['draw()'] = new_set({
 })
 
 T['draw()']['works'] = function()
-  mark_flaky()
-
   set_cursor(6, 1)
   child.lua('MiniIndentscope.draw()')
 
@@ -434,8 +431,6 @@ T['draw()']['uses correct highlight groups'] = new_set(
 )
 
 T['draw()']['respects `config.draw.animation`'] = function()
-  mark_flaky()
-
   local validate = function(duration)
     set_cursor(5, 4)
     child.lua('MiniIndentscope.draw()')
@@ -463,8 +458,6 @@ T['draw()']['respects `config.draw.animation`'] = function()
 end
 
 T['draw()']['respects `config.draw.priority`'] = function()
-  mark_flaky()
-
   local ns_id = child.api.nvim_create_namespace('indentscope-test')
   child.api.nvim_buf_set_extmark(0, ns_id, 4, 0, { virt_text_pos = 'overlay', virt_text = { { '+' } }, priority = 5 })
 
@@ -482,8 +475,6 @@ T['draw()']['respects `config.draw.priority`'] = function()
 end
 
 T['draw()']['respects `config.symbol`'] = function()
-  mark_flaky()
-
   child.lua([[MiniIndentscope.config.symbol = '-']])
   set_cursor(5, 4)
   child.lua('MiniIndentscope.draw()')
@@ -498,8 +489,6 @@ T['draw()']['respects `config.symbol`'] = function()
 end
 
 T['draw()']["does not overshadow 'listchars'"] = function()
-  mark_flaky()
-
   child.o.list = true
   child.o.listchars = 'space:.'
 
@@ -565,8 +554,6 @@ T['undraw()'] = new_set({
 })
 
 T['undraw()']['works'] = function()
-  mark_flaky()
-
   set_cursor(5, 4)
   child.lua('MiniIndentscope.draw()')
   child.expect_screenshot()
@@ -585,8 +572,6 @@ T['Auto drawing'] = new_set({
 })
 
 T['Auto drawing']['works in Normal mode'] = function()
-  mark_flaky()
-
   set_cursor(5, 4)
   sleep(default_draw_delay - small_time)
   -- Nothing should yet be shown
@@ -604,8 +589,6 @@ T['Auto drawing']['respects common events'] = new_set({
   parametrize = { { 'CursorMoved' }, { 'CursorMovedI' }, { 'TextChanged' }, { 'TextChangedI' }, { 'TextChangedP' } },
 }, {
   test = function(event_name)
-    mark_flaky()
-
     set_cursor(5, 4)
     child.lua('MiniIndentscope.undraw()')
     sleep(small_time)

tests/test_test.lua

@@ -5,7 +5,6 @@ local helpers = dofile('tests/helpers.lua')
 local child = helpers.new_child_neovim()
 local expect, eq = helpers.expect, helpers.expect.equality
 local new_set, finally = MiniTest.new_set, MiniTest.finally
-local mark_flaky = helpers.mark_flaky
 
 -- Helpers with child processes
 --stylua: ignore start
@@ -1453,8 +1452,6 @@ T['gen_reporter']['buffer'] = new_set({
   test = function(opts_element)
     if child.fn.has('nvim-0.10') == 0 then MiniTest.skip('Screenshots are generated for Neovim>=0.10.') end
 
-    mark_flaky()
-
     -- Testing "in dynamic" is left for manual approach
     local path = get_ref_path('testref_reporters.lua')
     local reporter_command = string.format('_G.reporter = MiniTest.gen_reporter.buffer({ %s })', opts_element)
@@ -1492,7 +1489,6 @@ T['gen_reporter']['stdout'] = new_set({
 }, {
   test = function(env_var)
     helpers.skip_on_windows('Terminal tests are designed for Unix')
-    mark_flaky()
 
     -- Testing "in dynamic" is left for manual approach
     local path = 'tests/dir-test/init_stdout-reporter_works.lua'