-
Notifications
You must be signed in to change notification settings - Fork 190
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(statusline): allow custom signs in
section_diagnostics()
Another approach would be to use sign text from `vim.diagnostic.config().signs.text`. However, it has downsides: - Users might want to show different severity levels in signcolumn and statusline. Not wanting info and hint levels in signcolumn but want in statusline seems like a pretty reasonable setup. - It is only present in Neovim>=0.10. For reverse compatibility, it should also use `vim.fn.sign_getdefined()`, which is cumbersome. - For best performance, some kind of caching should be done (otherwise execution time increases from median ~2.6 microseconds to ~4.7). Yet it is cumbersome to have it properly updated (and even created) without forcing `require('vim.diagnostic')` during startup. The price to pay for using `args.signs` is that it requires explicit (possibly duplicating) lines in config via the whole and verbose `active` content function. Resolve #769
- Loading branch information
1 parent
5ce69e4
commit 581d6f9
Showing
4 changed files
with
14 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters