SPM support, exposed the delegate method to the public #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repo seems to be abandoned since 2019, but this addition will be really useful for current implementations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added Swift Package Support for this framework and modified the way the
delegateis used.I believe it is better to allow any object to adopt the
CollectionViewWaterfallLayoutDelegate, not only the object that already conforms to theUICollectionViewDelegate.I think it allows for better separation of responsibilities and thus cleaner code.
☺️
Also, creating the layout like this:
let layout = CollectionViewWaterfallLayout(delegate: self)is more satisfying