Skip to content

Activity fetch behaviour #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Activity fetch behaviour #3555

wants to merge 3 commits into from

Conversation

@BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Jun 25, 2023

No description provided.

@BacLuc BacLuc marked this pull request as draft June 25, 2023 01:31
@BacLuc BacLuc added the deploy! Creates a feature branch deployment for this PR label Jun 25, 2023
@github-actions
Copy link

github-actions bot commented Jun 25, 2023 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@BacLuc BacLuc mentioned this pull request Aug 7, 2023
Merged
9 tasks
@BacLuc BacLuc mentioned this pull request Aug 15, 2023
Closed
@BacLuc BacLuc removed the deploy! Creates a feature branch deployment for this PR label Sep 5, 2023
@BacLuc
Copy link
Contributor Author

BacLuc commented Oct 10, 2023 •
edited
Loading

I tested the new uriTemplate feature of api-platform 3.2, and it has a big potential.
BacLuc#208

I propose we suspend our optimization effort without that feature, and use the uriTemplate feature as soon as we upgraded to api-platform 3.2

@BacLuc BacLuc closed this Oct 10, 2023
@usu
Copy link
Member

usu commented Oct 14, 2023

I tested the new uriTemplate feature of api-platform 3.2, and it has a big potential. BacLuc#208

I propose we suspend our optimization effort without that feature, and use the uriTemplate feature as soon as we upgraded to api-platform 3.2

Yeah, cool, good to see this works now.
Agree to close this PR.

For introduction of the new uriTemplate feature, I'd suggest to implement this within #3610 endpoint by endpoint, as I anyway need the subresource feature for the caching. But certainly up for discussion.

@BacLuc BacLuc deleted the activity-fetch-behaviour branch August 28, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BacLuc @usu