-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a section to Michelson Encoder doc about the breaking change, fix TypeCheck method example #3002
Conversation
…, fixed typecheck doc
A new deploy preview is available on Cloudflare Pages at https://321bee40.taquito-test-dapp.pages.dev |
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
Deploying taquito with Cloudflare Pages
|
docs/michelson_encoder.md
Outdated
} | ||
} | ||
``` | ||
You can enable the old behavior by setting the `Token.fieldNumberingStrategy = 'Legacy'`. Please not that this value should stay the same for the whole application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo 'please not'
} | ||
} | ||
``` | ||
You can enable the old behavior by setting the `Token.fieldNumberingStrategy = 'Legacy'`. Please not that this value should stay the same for the whole application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same typo here "please not"
docs/michelson_encoder.md
Outdated
|
||
Please run the code above and check the output. | ||
|
||
Please note how nested field numbers are not predictable. The field numbers are assigned in the order their parent were encountered during the traversal of the tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like these sentences can be improved a little bit, I think I understand them because I have context. Maybe something like
Please note that nested field numbers are unpredictable. Field numbers are assigned in the order of where their parent is encountered during the traversal of the tree.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks Ali
Closes #2969
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.