2958 eventsub

[dsawali]

closes #2958
Updated taquito beacon wallet to use subscribeToEvent instead of getActiveAccount

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

• Your code builds cleanly without any errors or warnings
• You have run the linter against the changes
• You have added unit tests (if relevant/appropriate)
• You have added integration tests (if relevant/appropriate)
• All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
• You have added or updated corresponding documentation
• If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

• You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
• You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

[github-actions]

A new deploy preview is available on Cloudflare Pages at https://79972cb6.taquito-test-dapp.pages.dev

[github-actions]

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/beacon-wallet@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/contracts-library@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/utils@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/ledger-signer@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/taquito@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip12@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/core@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/sapling@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michel-codec@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/http-utils@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/local-forging@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/timelock@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/signer@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/rpc@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/remote-signer@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michelson-encoder@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip16@19.2.1-beta.2-b6658d5-- --registry https://npm.preview.tezostaquito.io/

[cloudflare-workers-and-pages]

Deploying taquito with    Cloudflare Pages

Latest commit:	27cbfe0
Status:	✅  Deploy successful!
Preview URL:	https://8400859f.taquito.pages.dev
Branch Preview URL:	https://2958-eventsub.taquito.pages.dev

View logs

[ac10n]

One concern:
I the dApp code calls getPkh immediately after connecting, but before the first ACTIVE_ACCOUNT_SET event is received, they will get an error. Not sure if this is actually possible, or even if it's possible if there is a better solution.

[dsawali]

I don't think that will happen since the even will be subscribed to in the constructor. So getPkh will likely never be called unless the client has been constructed, and in consequence, the account member variable will always be assigned a value. And if it doesn't it will throw an error, so at least it signals the user (or developer) that the wallet has not been connected, or the wallet info is incomplete. I hope that makes sense!

[ac10n]

While the event is subscribed in the constructor, it might not be triggered until a split-second later

[dsawali]

hmm, I figured it would be a rare occurrence. But do you have any suggestions to improve it then?

[ac10n]

It might be a good idea to investigate if it's possible to create the error mentioned in comments. If so, we might want to add something to release notes.

[hui-an-yang]

Code change in packages/taquito-beacon-wallet/src/taquito-beacon-wallet.ts looks good!! Might be pointing to master makes this pr regressed some commit changes already in master rn. Other than that just would be good to have test-dapp to switch account to prove the change to subscribeToEvent will capture switching account successfully in beaconWallet class.