Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using static variable to configure field numbering strategy #2939

Merged

Conversation

ac10n
Copy link
Contributor

@ac10n ac10n commented Apr 25, 2024

This PR implements ability for developers to fall back to the legacy system for field numbering that is changed in #2929

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

Copy link

github-actions bot commented Apr 25, 2024

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/beacon-wallet@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/contracts-library@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/utils@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/ledger-signer@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/taquito@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip12@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/core@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/sapling@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michel-codec@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/http-utils@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/local-forging@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/timelock@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/signer@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/rpc@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/remote-signer@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michelson-encoder@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip16@19.2.0-bcd0444-- --registry https://npm.preview.tezostaquito.io/

Copy link

cloudflare-workers-and-pages bot commented Apr 25, 2024

Deploying taquito with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5aef47b
Status: ✅  Deploy successful!
Preview URL: https://26f17205.taquito.pages.dev
Branch Preview URL: https://2927-variant-typing-bug-meth.taquito.pages.dev

View logs

@ac10n ac10n marked this pull request as ready for review April 29, 2024 13:50
@ac10n ac10n force-pushed the 2927-variant-typing-bug-method2-static-option branch from 8e7fce1 to 690129f Compare April 30, 2024 18:48
@ac10n ac10n merged commit 6b03bce into 2927-variant-typing-bug May 2, 2024
7 checks passed
@ac10n ac10n deleted the 2927-variant-typing-bug-method2-static-option branch May 2, 2024 19:48
ac10n added a commit that referenced this pull request May 2, 2024
* feat: option for the user to choose between legacy and updated field numbering

* chore: fix typo

* chore: add typedoc comments for Token.fieldNumberingStrategy

* test: fix failing integration test
ac10n added a commit that referenced this pull request May 2, 2024
* feat: option for the user to choose between legacy and updated field numbering

* chore: fix typo

* chore: add typedoc comments for Token.fieldNumberingStrategy

* test: fix failing integration test
ac10n added a commit that referenced this pull request May 2, 2024
* feat: option for the user to choose between legacy and updated field numbering

* chore: fix typo

* chore: add typedoc comments for Token.fieldNumberingStrategy

* test: fix failing integration test
ac10n added a commit that referenced this pull request May 2, 2024
…correctly (#2929)

* fix: the idx of a pair inside or inside pair is not calculated correctly

* chore: update tests

* test: fix failing unit tests

* test: fix failing integration test

* Using static variable to configure field numbering strategy (#2939)

* feat: option for the user to choose between legacy and updated field numbering

* chore: fix typo

* chore: add typedoc comments for Token.fieldNumberingStrategy

* test: fix failing integration test

* test: comment in the integration test to make it clear that we are testing all three strategies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants