-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using static variable to configure field numbering strategy #2939
Merged
ac10n
merged 4 commits into
2927-variant-typing-bug
from
2927-variant-typing-bug-method2-static-option
May 2, 2024
Merged
Using static variable to configure field numbering strategy #2939
ac10n
merged 4 commits into
2927-variant-typing-bug
from
2927-variant-typing-bug-method2-static-option
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
Deploying taquito with Cloudflare Pages
|
ac10n
force-pushed
the
2927-variant-typing-bug-method2-static-option
branch
from
April 30, 2024 18:48
8e7fce1
to
690129f
Compare
dsawali
approved these changes
May 1, 2024
ac10n
added a commit
that referenced
this pull request
May 2, 2024
* feat: option for the user to choose between legacy and updated field numbering * chore: fix typo * chore: add typedoc comments for Token.fieldNumberingStrategy * test: fix failing integration test
ac10n
added a commit
that referenced
this pull request
May 2, 2024
* feat: option for the user to choose between legacy and updated field numbering * chore: fix typo * chore: add typedoc comments for Token.fieldNumberingStrategy * test: fix failing integration test
ac10n
added a commit
that referenced
this pull request
May 2, 2024
* feat: option for the user to choose between legacy and updated field numbering * chore: fix typo * chore: add typedoc comments for Token.fieldNumberingStrategy * test: fix failing integration test
ac10n
added a commit
that referenced
this pull request
May 2, 2024
…correctly (#2929) * fix: the idx of a pair inside or inside pair is not calculated correctly * chore: update tests * test: fix failing unit tests * test: fix failing integration test * Using static variable to configure field numbering strategy (#2939) * feat: option for the user to choose between legacy and updated field numbering * chore: fix typo * chore: add typedoc comments for Token.fieldNumberingStrategy * test: fix failing integration test * test: comment in the integration test to make it clear that we are testing all three strategies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ability for developers to fall back to the legacy system for field numbering that is changed in #2929
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.