-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed mumbai references in v17 #2511
Conversation
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
packages/taquito-rpc/src/types.ts
Outdated
@@ -1915,6 +1916,11 @@ export interface ConstantsResponseCommon { | |||
|
|||
export type Ratio = { numerator: number; denominator: number }; | |||
|
|||
export interface ConstantsResponseProto017 extends ConstantsResponseProto016 { | |||
attestation_threshold: number; | |||
blocks_per_epoch: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it matter that these two added properties seem to belong under this parent property dal_parametric
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, I'll adjust it instead so that 17 merely extends 16, and update the dal_parametric object to have the 2 new properties as optional properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🌟
* Configure Nairobinet for Integration Tests (#2492) * Configure Nairobinet * More Nairobinet configs * Originated known contracts * Configure Nairobinet for Integration Tests (#2492) * Configure Nairobinet * More Nairobinet configs * Originated known contracts * Update nairobi in other files (#2506) * Update nairobi in other files * undo changes to versioned docs * chore: rename PtNairob to PtNairobi * 2447 update gas limit for reveal in nairobi (#2494) * feat: updated GasLimit for reveal in Nairobi fix #2447 * fix: change mumbai tests to also run for later protocols * chore: fix failing unit tests * Fix failoing integration test * chore: rename PtNairob to PtNairobi * chore: apply changes as suggested by davis * chore: remove the unused logic * chore: fix values for the consumedMilligas in failing tests * fix unit tests after changes to reveal gasLimit * chore: revert gas limit for reveal to 2200 * Add EventSchema to ContractAbstraction (#2485) * fixed contract call estimate prep to check for reveal (#2502) * fixed contract call estimate prep to check for reveal * changed logic slightly * added keygen diagram to integration test readme (#2504) * added keygen diagram * text improvement * typo fix * Upgrade netlify-cli to fix the android dependency problem (#2496) * Re-create package-lock.json in root and website to trigger the problem * Upgrade netlify-cli * update most dependencies in website * Add EventSchema to ContractAbstraction * Remove duplicate events * fix typo * test: added integration test for events in ContractAbstraction * docs: add documentation for eventSchema --------- Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com> Co-authored-by: Michael Kernaghan <michaelkernaghan@ecadlabs.com> * removed mumbai references in v17 (#2511) * removed mumbai references in v17 * add block call for mumbai to get protocol constants * remove extraneous line * updated assertion values * updated assertion * fix test protocol constants * addressed pr comment and added proto15 tests * updated types for sc_rollup_cement in N (#2497) * Configure Nairobinet for Integration Tests (#2492) * Configure Nairobinet * More Nairobinet configs * Originated known contracts * updated types for sc_rollup_cement in N * updated unit test for updated types --------- Co-authored-by: AlirezaHaghshenas <alirezahaghshenas@gmail.com> * Both Mumbai and Nairobi integration test configurations should coexist * 1996 rpc 2 (#2522) * added validation for transferred amounts and updated readme * update flextesa image version * update sequence of test * chore(releng) bump version to 17.0.0-beta-RC.0 * chore: satisfy lerna * chore(releng) bump version to 17.0.0 --------- Co-authored-by: AlirezaHaghshenas <alirezahaghshenas@gmail.com> Co-authored-by: Michael Kernaghan <michaelkernaghan@ecadlabs.com> Co-authored-by: Daniele Lisi <22307776+danielelisi@users.noreply.github.com>
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.