Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed angular webpack config path in postinstall patch script #140

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

mbykovskyy
Copy link
Contributor

@mbykovskyy mbykovskyy commented Oct 7, 2019

What worries me is that Angular Truffle Box, Ethereum Web3.js, and now Taquito all have different path for angular web pack config.

Ethereum Web3.js patch points to '../../node_modules/@angular-devkit/build-angular/src/angular-cli-files/models/webpack-configs/browser.js'

Angular Truffle Box patch points to 'node_modules/@angular-devkit/build-angular/src/angular-cli-files/models/webpack-configs/browser.js'

Taquito patch points to '../../@angular-devkit/build-angular/src/angular-cli-files/models/webpack-configs/browser.js'

This makes me believe that either my local test didn't do what npm install does or NPM has changed the CWD of post install scripts.

@codecov-io
Copy link

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   77.69%   77.69%           
=======================================
  Files          59       59           
  Lines        1941     1941           
  Branches      408      408           
=======================================
  Hits         1508     1508           
  Misses        430      430           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016f211...80f2e90. Read the comment docs.

@carte7000 carte7000 merged commit 57323c7 into master Oct 11, 2019
@carte7000 carte7000 deleted the angular-webpack-patch branch October 11, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants