Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(site-header): Removing containers when removing notification - FRONT-4637 #3656

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix(site-header): Removing containers when removing notification - FRONT-4637 #3656

merged 3 commits into from
Oct 1, 2024

Conversation

planctus
Copy link
Collaborator

@planctus planctus commented Oct 1, 2024

…

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

🚀 Deployed on https://ecl-preview-3656--europa-component-library.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 08:18 Inactive
@planctus planctus marked this pull request as ready for review October 1, 2024 08:52
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 08:59 Inactive
emeryro
emeryro reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not seem to work on my side (or maybe I misunderstood what it is supposed to do).

Here is what I tested:

  • display the notification, the border is visible
    image
  • close the notification by clicking on the cross button; the border is still there
    image

@planctus
Copy link
Collaborator Author

planctus commented Oct 1, 2024

ops.. :) Hard to remove something based on something that has been already removed..

@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 11:47 Inactive
@emeryro emeryro merged commit 9823084 into v4-dev Oct 1, 2024
7 checks passed
@emeryro emeryro deleted the FRONT-4637-Site-header-notification-close branch October 1, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeryro emeryro emeryro approved these changes

Assignees
No one assigned
Labels
tag: bug fix tag: markup changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@planctus @emeryro