-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mega-menu): Mega menu content position fix - FRONT-4606 #3615
Conversation
I get the idea behind this task, but the result design is quite odd (site header has some padding while the mega menu takes 100% width) Maybe we could keep the scrollbar, but just "disable" it. I found this for instance, that seems to work:
https://stackoverflow.com/questions/8701754/how-to-disable-scroll-without-hiding-it |
mmh..i tried with position: fixed already but i gave up for a reason: in desktop you could open the menu after having scrolled the page a bit, using position: fixed will reset that scroll and bring the page back to top: 0; I haven't noticed myself the issue with the padding being set on the body and the menu still getting the full width, so i chose this solution, but comparing the two it seems a minor issue the one described before with the position fixed, so let's go with it |
The fix is fine, so to me this task can be merged already. |
…y into FRONT-4606-Mega-menu-content-position-fix
…m:ec-europa/europa-component-library into FRONT-4606-Mega-menu-content-position-fix
No description provided.