Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(video): Initializing the _extra_attributes variable - FRONT-4590 #3594

Merged
merged 2 commits into from
Sep 2, 2024
Merged

fix(video): Initializing the _extra_attributes variable - FRONT-4590 #3594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb2e1fc
fix(video): Initializing the _extra_attributes variable - FRONT-4590
planctus Aug 30, 2024
87b997b
Merge branch 'v4.6.3-dev' into FRONT-4590-Video-extra-attr
emeryro Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/implementations/twig/components/video/video.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
{% set _title = title|default('') %}
{% set _sr_video_player = sr_video_player|default('') %}
{% set _sr_video_label = sr_video_label|default('') %}
{% set _extra_attributes = '' %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be an empty array instead of a string?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is the local variable, it's a string


{% if _controls %}
{% set _extra_attributes = 'controls' %}
Expand Down
Loading