Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site-header): fixing language switcher in rtl - FRONT-4569 #3561

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

planctus
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Aug 13, 2024

@github-actions github-actions bot temporarily deployed to pull request August 13, 2024 07:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 13, 2024 13:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 13, 2024 14:21 Inactive
@planctus planctus marked this pull request as ready for review August 13, 2024 14:22
@emeryro
Copy link
Contributor

emeryro commented Aug 14, 2024

This looks fine, but we are in a confusing situation I think: we have the extra css for rtl, and still we are adding things related to rtl in the main css.
We should try to clean up a little that topic (probably in a major version)

@github-actions github-actions bot temporarily deployed to pull request August 14, 2024 07:42 Inactive
@planctus
Copy link
Collaborator Author

Yep, true, but i would really find it hard to handle situations like this in two separated css, it would be really unconvenient and the advantage in terms of heaviness of the "main" css is really minor, moving those rules outside of it.
I think i have never looked at the rtl css, i would expect it to be something more "generic" to make adaptations when needed, but handling the single components styles in it seems unconvenient, in the end it's a matter of the amount of changes needed for the rtl to work properly, in this case it's not really much and hopefully the same for many other components, otherwise we would probably decide to generate two scss files (three including the print) per component.

@planctus planctus removed the Question label Aug 14, 2024
@github-actions github-actions bot temporarily deployed to pull request August 14, 2024 08:24 Inactive
@emeryro emeryro merged commit 861c69c into v4-dev Aug 14, 2024
6 of 7 checks passed
@emeryro emeryro deleted the FRONT-4569-Site-header-popover-arrows-in-rtl branch August 14, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants