-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(headings): set spacing - FRONT-4566 #3552
Conversation
mmh..does it make sense to add this to utilities that are only meant to deal with the font styles? I mean, if a utility class is used then it's not an issue to add another one, to set a margin being able to decide this margin every time. |
I would say yes and no... We can indeed guess that if a user adds a utility somewhere, he is able to add 2 more. But then he would have to know what spacing should be used, to keep consistency. |
but, imagine all the current usage of these utilities, now they will get a margin where they hadn't before, i really don't see why doing this, it's not just a matter of consistency, it's really that doing this will surely have an impact and i don't see the need for this, we can offer a way to handle spacing through headings in a specific context like what we do in the default css, no need to extend this to the utilities, imo. |
Just to be clear: there is already a margin on all headings; it is just provided by the browser. This update would set it to a fixed value. |
.ecl-u-type-heading-x
) and heading used in wysiwyg, using.ecl hx