Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headings): set spacing - FRONT-4566 #3552

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Aug 7, 2024

  • set same spacing for all headings; it applies to utilities (.ecl-u-type-heading-x) and heading used in wysiwyg, using .ecl hx

Copy link

github-actions bot commented Aug 7, 2024

@github-actions github-actions bot temporarily deployed to pull request August 7, 2024 11:54 Inactive
@planctus
Copy link
Collaborator

mmh..does it make sense to add this to utilities that are only meant to deal with the font styles? I mean, if a utility class is used then it's not an issue to add another one, to set a margin being able to decide this margin every time.
I thought this would have only been affecting the ecl-default, basically, to make it possible to quickly create a layout with heading and text without the overhead of creating a spacing between them.

@emeryro
Copy link
Contributor Author

emeryro commented Aug 13, 2024

I would say yes and no... We can indeed guess that if a user adds a utility somewhere, he is able to add 2 more. But then he would have to know what spacing should be used, to keep consistency.
Adding it directly in the heading utilities is more straightforward, even if that goes a little outside of the "typography" scope...

@planctus
Copy link
Collaborator

but, imagine all the current usage of these utilities, now they will get a margin where they hadn't before, i really don't see why doing this, it's not just a matter of consistency, it's really that doing this will surely have an impact and i don't see the need for this, we can offer a way to handle spacing through headings in a specific context like what we do in the default css, no need to extend this to the utilities, imo.

@emeryro
Copy link
Contributor Author

emeryro commented Aug 14, 2024

Just to be clear: there is already a margin on all headings; it is just provided by the browser. This update would set it to a fixed value.
But let's check that with COMM, to be aligned

@planctus planctus removed the Question label Aug 14, 2024
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 08:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 08:48 Inactive
@planctus planctus merged commit 20899c9 into v4-dev Aug 22, 2024
6 of 7 checks passed
@planctus planctus deleted the FRONT-4566-heading-spacing branch August 22, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants