Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(featured-item): change order - FRONT-4476 #3515

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Jul 24, 2024

No description provided.

Copy link

github-actions bot commented Jul 24, 2024

@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 06:29 Inactive
@emeryro emeryro marked this pull request as ready for review July 25, 2024 07:48
@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 07:56 Inactive
@planctus
Copy link
Collaborator

This rule is now creating an additional spacing in the item containing the media:
image

@planctus
Copy link
Collaborator

planctus commented Jul 26, 2024

is this accessibility request implying also a total change in the mobile design..?
image

we used to have the image on top and now it's the opposite

@planctus
Copy link
Collaborator

We have this in mobile for the highlighted:
image
no "spacing"after the link, but maybe this comes simply out of the inversion of the items order

@github-actions github-actions bot temporarily deployed to pull request July 29, 2024 10:51 Inactive
@planctus planctus merged commit c92fe47 into v4-dev Jul 30, 2024
7 checks passed
@planctus planctus deleted the FRONT-4476-acc-featured-item-order branch July 30, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants