feat(mega-menu): Adding style for the current sub-items in desktop - FRONT-4527 #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
changed the title
emeryro
approved these changes
Jul 18, 2024
…y into FRONT-4527-Sub-item-current-style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed in this pr the work just done to replace the link with a button for the toggle. Not sure the reason why but that was breaking the switch between ltr/rtl, this brings back the "link" markup, but as we are in the process of replacing directly in the markup all these links with buttons, there is no need for this solution using js. In this pr i fixed a bit the rtl display as well, particularly the position of the toggle.