Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gallery): design update - FRONT-4387 #3390

Merged
merged 19 commits into from
Jun 13, 2024
Merged

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented May 15, 2024

  • display title instead of description in the teaser
  • reorder elements in the overlay (previous/next buttons)
  • display title in the overlay
  • remove truncation of the description, but display it full width

@emeryro emeryro changed the title feat(gallery): design update feat(gallery): design update - FRONT-4387 May 15, 2024
Copy link

github-actions bot commented May 15, 2024

@github-actions github-actions bot temporarily deployed to pull request May 15, 2024 09:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2024 10:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2024 10:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 16, 2024 06:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 16, 2024 07:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 16, 2024 12:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 16, 2024 13:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 16, 2024 13:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 23, 2024 10:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 23, 2024 11:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 11:03 Inactive
@planctus
Copy link
Collaborator

something broke, the same happened in the slider, guess it's about buttons:
image

@emeryro
Copy link
Contributor Author

emeryro commented Jun 13, 2024

@planctus indeed that seem to be an issue introduced when we worked on the single icons set.
I set the display to inline-flex, it should be fine now.

@github-actions github-actions bot temporarily deployed to pull request June 13, 2024 06:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 13, 2024 07:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 13, 2024 07:57 Inactive
@planctus planctus merged commit 6cdcbb4 into v4-dev Jun 13, 2024
7 checks passed
@planctus planctus deleted the FRONT-4387-gallery-update branch June 13, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants