-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): Removing buggy animation of the arrow in the default select - FRONT-4348 #3318
Conversation
not sure what is the issue here, but on my side the arrow animation still doesn't work as expected. |
The issue is that currently, if you click outside of the select to close it, the animation doesn't work anymore, in this pull request this is fixed, but it's true that we cannot fully handle the first usage of Esc, which results in closing the dropdown without animating the select, but this is a minor issue to me, considering that when you move the focus out the arrow will go back to its default position. Aside of this, why do we have this huge difference in the icon size for the single and the multiple select now..? |
…y into FRONT-4348-Default-select-animation
Tried a bit more, but it seems really impossible to produce a logic that would work for all the browsers and it's also confirmed by the literature on internet, so i removed the animation from the default select. |
…y into FRONT-4348-Default-select-animation
…uropa/europa-component-library into FRONT-4348-Default-select-animation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -15,7 +15,7 @@ const iconSize = system === 'eu' ? 's' : 'xs'; | |||
|
|||
/** | |||
* This API mostly refers to the multiple select, in the default select only three methods are actually used: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* This API mostly refers to the multiple select, in the default select only three methods are actually used: | |
* This API mostly refers to the multiple select, in the default select only two methods are actually used: |
…lect - FRONT_4348
No description provided.